-
-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make attributes tapable in the Summary card #1029
Comments
This is the conversation we had with Stephene:
Backend will soon send the corresponding knowledge panel id for each
attribute via attributes api, we can use that to open up (or scroll to)
the corresponding knowledge panel.
…On Thu, Jan 27, 2022, 18:48 Pierre Slamich ***@***.***> wrote:
What
- On the summary card and elsewhere, I kind of expect to be able to
tap to get a proof
- eg on the summary card, tapping on not vegan might show a new
screen why it’s not vegan
- pressing on Ultra-processed might show the ultra-processing
markers + a reference to NOVA 4
We need a new server side link. cc @stephanegigandet
<https://github.com/stephanegigandet>
—
Reply to this email directly, view it on GitHub
<#1029>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZRHYT5DPDMMNP3ZALL7Q3UYGAOTANCNFSM5M6T5LNQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Corresponding PR on the server: openfoodfacts/openfoodfacts-server#6493 |
It's on dev, so it should be possible to start using dev mode @jasmeet0817 @g123k : |
@M123-dev could you have a look at this one ? |
I'll have a look at it tomorrow |
When I understood your request right @teolemon we now expose a panel_id on the summary card and when clicked on it we should open the expanded knowledge panel for it right? |
Yes, exactly |
What
feat: link product attributes to knowledge panels openfoodfacts-server#6493
Part of
The text was updated successfully, but these errors were encountered: