Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text "terms of use and contribution" stays blue in color on changing the app theme #1327

Closed
Gagarod opened this issue Mar 25, 2022 · 6 comments
Labels
darkmode Ensuring we look good in the dark

Comments

@Gagarod
Copy link
Contributor

Gagarod commented Mar 25, 2022

What

  • The text "terms of use and contribution" in the Create Account section does not change its color on changing the theme.

Steps to reproduce the behavior

  1. Change App theme
  2. Go to Profile Tab
  3. Click on SignIn
  4. Click on Create Account button
  5. The "terms of use and contribution" is still blue in color

Part of

Screenshot/Mockup/Before-After

Dark theme Green Color
dark green
@vik4114
Copy link
Contributor

vik4114 commented Mar 25, 2022

@Gagarod I think that's okay

@Gagarod
Copy link
Contributor Author

Gagarod commented Mar 25, 2022

@Gagarod I think that's okay

but that doesn't match with the UI. Should I change this?

@AshAman999
Copy link
Member

@Gagarod I think that's okay

but that doesn't match with the UI. Should I change this?

let the maintainers have a look, they will suggest the best

@M123-dev
Copy link
Member

All links in the app are blue and underlined, so that it's clear that they are links, but I don't have a strong opinion on whether they should change color or not

@PrabeshPP
Copy link
Contributor

@Gagarod I think the blue color looks good with both dark and light theme.

@teolemon teolemon added the darkmode Ensuring we look good in the dark label Mar 31, 2022
@teolemon teolemon added this to the V2 milestone Apr 11, 2022
@M123-dev
Copy link
Member

I think we can close, if not feel free to reopen or open another one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
darkmode Ensuring we look good in the dark
Development

No branches or pull requests

6 participants