Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict max number of product scans. #1637

Closed
bhattabhi013 opened this issue Apr 23, 2022 · 9 comments
Closed

Restrict max number of product scans. #1637

bhattabhi013 opened this issue Apr 23, 2022 · 9 comments

Comments

@bhattabhi013
Copy link
Contributor

Problem

The user can scan as many products as he wants.

Proposed solution

Cap max number of scan cards on the scan page to 25.

Part of

@bhattabhi013 bhattabhi013 changed the title Restrict max number of scans to 25. Restrict max number of product scans. Apr 23, 2022
@monsieurtanuki
Copy link
Contributor

As an end-user I do not support this issue. When I read "The user can scan as many products as he wants.", I said "Of course!". Then I said that it was considered as a problem...

Regardless, whatever is done here, you guys must be clever about the UX:

  • 25 is only half of the number of breakfast cereals in my shop. If I want to do a "breakfast cereals" session, would that be possible?
  • OK you want to cap to 25. What happens if I try to scan number 26? A blue screen of death? A message? What action is needed then on the user side?
  • Will that be capped only on the carousel or also on the (future) scan product list page?
  • I suggest as a test to lower the limit to 5

@bhattabhi013
Copy link
Contributor Author

Hi @monsieurtanuki,

  • As of now, I was thinking to display a message to the user when he tries to scan the 26th product and he can remove some individual products from the earlier scanned list.
  • I thought of starting the capping with the carousel and then proceeding with the user experience.

After reading your comments and suggestions above, I think you are right, if we say that the user can scan as many products as he wants and then limit the scans to 25 won't make any sense.

@monsieurtanuki
Copy link
Contributor

What makes sense is saying that the carousel is not well designed for 25 items. And the user should be able to clear the carousel or remove chosen items. How can the user do that today?

@M123-dev
Copy link
Member

Current status:

@monsieurtanuki
Copy link
Contributor

Thank you @M123-dev. Soon the user will be able to display the scan list a bit like the history, and to dismiss items from it.
What shall we do then for the current issue? Maybe open a pop-up after 25 items "hey it's a bit too much, do you want to remove some items?" and open the scan history page?

@teolemon
Copy link
Member

@monsieurtanuki
Copy link
Contributor

@teolemon I'm currently working on lists. But I cannot work on #1295 (I cannot scan on my emulator). @bhattabhi013 Do you feel like working on #1295 instead of this current issue?

@bhattabhi013
Copy link
Contributor Author

Sure, I'll work on #1295 . Should I close this one?

@monsieurtanuki
Copy link
Contributor

@bhattabhi013 Yes please close it. You'll reopen it or open a new issue if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants