Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We don't need android.permission.RECORD_AUDIO #3971

Closed
teolemon opened this issue May 17, 2023 · 4 comments · Fixed by #4085
Closed

We don't need android.permission.RECORD_AUDIO #3971

teolemon opened this issue May 17, 2023 · 4 comments · Fixed by #4085
Assignees
Labels
🐛 bug Something isn't working 🎯 P1 permissions 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…

Comments

@teolemon
Copy link
Member

teolemon commented May 17, 2023

What

  • We don't need android.permission.RECORD_AUDIO

Part of

Warning

Anomalous Permission Usage
Your app is requesting permissions which are used by less than 1% of functionally similar apps:

android.permission.RECORD_AUDIO
Users prefer apps that request fewer permissions and requesting unnecessary permissions can affect your app's visibility on the Play Store. If these permissions aren't necessary, you may be able to use alternative methods in your app and request fewer permissions. If they are, we recommend providing an explanation to users of why you need the permissions.

Note: This guidance is based on a comparison with functionally similar apps, which change over time as new apps get published and existing apps change behavior. Therefore the warning may change even if you don't change your permission usage.
@teolemon teolemon added 🐛 bug Something isn't working permissions labels May 17, 2023
@monsieurtanuki monsieurtanuki self-assigned this May 17, 2023
@monsieurtanuki
Copy link
Contributor

@teolemon With camera you can record videos:
https://github.com/flutter/packages/blob/main/packages/camera/camera_android/android/src/main/AndroidManifest.xml

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
  package="io.flutter.plugins.camera">
    <uses-permission android:name="android.permission.CAMERA"/>
    <uses-permission android:name="android.permission.RECORD_AUDIO"/>
</manifest>

For the record we have a very very limited use of camera (basically, we just want to know how many cameras there are).
Therefore we could get rid of this package and find an alternate package. Or copy the "get number of cameras" code into Smoothie.

@teolemon teolemon added 🎯 P1 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… labels May 29, 2023
@monsieurtanuki monsieurtanuki removed their assignment Jun 2, 2023
@monsieurtanuki
Copy link
Contributor

Will depend on the new new new barcode scan tool.

@monsieurtanuki
Copy link
Contributor

Screenshot_2023-06-05-13-10-42

@g123k
Copy link
Collaborator

g123k commented Jun 6, 2023

We can force the project to not inherit for this permission.
I will fix that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🎯 P1 permissions 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Development

Successfully merging a pull request may close this issue.

3 participants