Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't block the screen while saving a Hunger Games answer #4020

Closed
teolemon opened this issue May 26, 2023 · 3 comments · Fixed by #4099
Closed

Don't block the screen while saving a Hunger Games answer #4020

teolemon opened this issue May 26, 2023 · 3 comments · Fixed by #4099
Assignees
Labels
🐛 bug Something isn't working Hunger Games

Comments

@teolemon
Copy link
Member

What

  • Don't block the screen while saving a Hunger Games answer

Part of

Video

screen-20230526-103146.2.mp4
@teolemon teolemon added 🐛 bug Something isn't working Hunger Games labels May 26, 2023
@monsieurtanuki monsieurtanuki self-assigned this Jun 2, 2023
@monsieurtanuki
Copy link
Contributor

@teolemon I'm working on it: with background tasks the response to a hunger games question is "immediately" sent to the server.
The problem is that you still have to wait, before the next question is asked, for its product to be downloaded. In that case you don't wait with a "running..." dialog, but you wait with an empty hunger games card with a shimmering effect. I'm not convinced it is that significantly faster with low connectivity, and I'm not convinced the UI/UX is good either.

@teolemon
Copy link
Member Author

teolemon commented Jun 7, 2023

  • we can ask for a larger number of Robotoff questions
  • Do we really need to load all the whole products? Can we not load the whole images, data, on a per product basis when needed ?

@monsieurtanuki
Copy link
Contributor

  • we can ask for a larger number of Robotoff questions

Actually I think we already download a set of questions. Each may be about a different product.
What we could do is then to download all products in bulk first, instead of stuttering after each answer waiting for the next product to be loaded.

  • Do we really need to load all the whole products? Can we not load the whole images, data, on a per product basis when needed ?

That would make sense, but with a better UI. For the moment we already get the relevant image url and the name from the question. But when we click on the small image, we go to the downloaded product image page. We could instead go to a full screen zoomable page only with the question image. That would make sense, as the question is only about that image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working Hunger Games
Development

Successfully merging a pull request may close this issue.

2 participants