Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search view: WTF is this red background? #4205

Closed
g123k opened this issue Jun 18, 2023 · 7 comments
Closed

Search view: WTF is this red background? #4205

g123k opened this issue Jun 18, 2023 · 7 comments
Assignees

Comments

@g123k
Copy link
Collaborator

g123k commented Jun 18, 2023

Hi everyone!

Another UX issue in the app: we can swipe to remove a search term:
IMG_0027

But how can a user understand what's going on with this action?
In the history, we have at least a bin icon:
IMG_0028

@khanjasir90
Copy link
Contributor

@g123k so we just need to add a delete icon to make the context more relevant? I'll take this one up.

@g123k
Copy link
Collaborator Author

g123k commented Jun 18, 2023

Basically yes, but don't forget the accessibility side (the use of a Semantics widget)

@tanishq5414
Copy link

tanishq5414 commented Jul 3, 2023

I noticed this issue while working on the search_history_page.dart. I have the fix ready and will submit a pull request if no one else has it assigned already.
image

@g123k
Copy link
Collaborator Author

g123k commented Jul 3, 2023

I noticed this issue while working on the search_history_page.dart. I have the fix ready and will submit a pull request if no one else has it assigned already. image

That's OK. Basically, you just have to add the bin icon.
Please also don't forget the a11y, we want to improve the app in this field

@tanishq5414
Copy link

Yeah, could you explain what is a11n I am not aware of what it is?

@g123k
Copy link
Collaborator Author

g123k commented Jul 3, 2023

Yeah, could you explain what is a11n I am not aware of what it is?

The accessibility

@g123k
Copy link
Collaborator Author

g123k commented Jul 22, 2023

Fixed as part of #4338

@g123k g123k closed this as completed Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants