Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seldom I can't take a picture #4304

Closed
g123k opened this issue Jul 14, 2023 · 4 comments
Closed

Seldom I can't take a picture #4304

g123k opened this issue Jul 14, 2023 · 4 comments
Assignees
Labels
🐛 bug Something isn't working

Comments

@g123k
Copy link
Collaborator

g123k commented Jul 14, 2023

Hi everyone,

By testing the app this morning, I tried to take a picture, but I couldn't save sue to a the message "Saving a local version…":
https://github.com/openfoodfacts/smooth-app/assets/246838/8349f640-ae29-45ee-8978-36cd70d4ede2

@monsieurtanuki
Copy link
Contributor

@g123k For the record I've just tried to save a new (slightly cropped) image from my smartphone gallery and it was successful ("fake" ingredients for https://fr.openfoodfacts.org/produit/9780000000040).

It would be very interesting to understand in which cases saving the local image does not work:

  • crop area too small (I've also tried and had no problem)
  • crop area too big (I had no problem with my initial test)
  • isolate not working
  • or bad luck

If you're able to reproduce the bug on demand, what does the exception say?

@g123k
Copy link
Collaborator Author

g123k commented Jul 14, 2023

Unfortunately, when restarting the app, it worked again.
Hence, my PR to try to debug the issue

@monsieurtanuki monsieurtanuki self-assigned this Jul 15, 2023
@monsieurtanuki
Copy link
Contributor

Still to do: cf. #4305 (basically catch an exception on the isolate and use the standard async as a fallback, in image_compute_container.dart).

@monsieurtanuki monsieurtanuki changed the title I can't take a picture anymore Seldom I can't take a picture Jul 16, 2023
@g123k
Copy link
Collaborator Author

g123k commented Jul 17, 2023

The two PRs being merged, I close the issue.

@g123k g123k closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Development

No branches or pull requests

2 participants