Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We must improve the loading card #4312

Closed
g123k opened this issue Jul 14, 2023 · 4 comments · Fixed by #4318
Closed

We must improve the loading card #4312

g123k opened this issue Jul 14, 2023 · 4 comments · Fixed by #4318

Comments

@g123k
Copy link
Collaborator

g123k commented Jul 14, 2023

Hi everyone!

We have many people complaining that the app doesn't work/doesn't find products.
It's difficult to understand exactly the problem behind it, but today I was possibly able to be in their situation.

Basically, it happens when the server is really slow and my app was stuck on the loading card for at least 10 seconds:
Screenshot_20230714-132221

Even if we can't do better than a loading card, we should improve the UI of it, to at least provide something less formal/minimal.

@monsieurtanuki
Copy link
Contributor

@g123k Fair enough!

Some suggestions:

  • a "try later" button
  • a 10 second timeout after which we display a "Unfortunately, slow connection or slow server", with a "retry" button
  • a more explicit card title "Looking for product 01234"
  • a faster server (db, memory, ...) (but that's another story)

@g123k
Copy link
Collaborator Author

g123k commented Jul 15, 2023

@g123k Fair enough!

Some suggestions:

  • a "try later" button

Actually, the requesting is still in progress, so not yet 😅

  • a 10 second timeout after which we display a "Unfortunately, slow connection or slow server", with a "retry" button

I think that will be one part of my implementation.
The other one is that I animate the OFF logo or use the fruits/vegetables visual from empty lists and do a nice animation

  • a more explicit card title "Looking for product 01234"

And also, obviously.

  • a faster server (db, memory, ...) (but that's another story)

This is a work that @alexgarel is working on. It will take some time unfortunately to do all the migration stuff and co

@monsieurtanuki
Copy link
Contributor

a "try later" button

Let's call it "stop and try later" then.

@g123k
Copy link
Collaborator Author

g123k commented Jul 15, 2023

Actually, we can mix everything:

  1. Text with "loading barcode XXXXX" with an animation
  2. After 7-8 sec : "Unfortunately, slow connection or slow server"
  3. After 5 more seconds: Retry button

@g123k g123k linked a pull request Jul 15, 2023 that will close this issue
@g123k g123k self-assigned this Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants