Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why do we have an ingredients AND origins section? #4325

Closed
g123k opened this issue Jul 16, 2023 · 1 comment · Fixed by #4336
Closed

Why do we have an ingredients AND origins section? #4325

g123k opened this issue Jul 16, 2023 · 1 comment · Fixed by #4336
Labels
translations

Comments

@g123k
Copy link
Collaborator

g123k commented Jul 16, 2023

Hi everyone,

In the product edition, we have two entries:

  • Ingredients and origins
  • Origins

Basically, my question: shouldn't we rename Ingredients and origins to Ingredients?

Screenshot_1689535831
@g123k g123k changed the title We do we have an ingredients AND origins section? Why do we have an ingredients AND origins section? Jul 16, 2023
@monsieurtanuki
Copy link
Contributor

Basically, my question: shouldn't we rename Ingredients and origins to Ingredients?

+1

g123k added a commit that referenced this issue Jul 19, 2023
@g123k
chore: Rename "Ingredients and Origins" to "Ingredients"
ca2b81d 
As explained in #4325, we have a dedicated "Origins" section.
The Ingredients one, should not mention origins, because they shouldn't be there
@g123k g123k mentioned this issue Jul 19, 2023
Merged
@g123k g123k linked a pull request Jul 19, 2023 that will close this issue
chore: Rename "Ingredients and Origins" to "Ingredients" #4336
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
translations
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Rename "Ingredients and Origins" to "Ingredients" openfoodfacts/smooth-app
2 participants
@g123k @monsieurtanuki