Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change icon as well as color for completed items in road to score #4335

Closed
Tracked by #4248
alexgarel opened this issue Jul 19, 2023 · 7 comments · Fixed by #4739
Closed
Tracked by #4248

Change icon as well as color for completed items in road to score #4335

alexgarel opened this issue Jul 19, 2023 · 7 comments · Fixed by #4739
Assignees
Labels
Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.

Comments

@alexgarel
Copy link
Member

alexgarel commented Jul 19, 2023

Currently we have the same icon for completed panels, only the color change.

Problem

This is not ok for users that do not see color well.
This is not even ok for other users as it makes the button brighter than the other (more prone to click), and the information the green convey is not obvious. I regularly click on the green button thinking info is not there…

Proposed solution

Change icon to an icon that shows completion.

Part of

@alexgarel alexgarel changed the title Change icon as well as color for completed items Change icon as well as color for completed items in road to score Jul 19, 2023
@g123k g123k self-assigned this Jul 19, 2023
@g123k
Copy link
Collaborator

g123k commented Jul 19, 2023

I will work on this to change a bit the UI.
But there are PRs that need to be merge first.

@monsieurtanuki
Copy link
Contributor

Change icon to an icon that shows completion.

@alexgarel I suggest traffic lights for green, orange and red. But I'm not sure we're talking about the same icons.

@teolemon teolemon added Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users. labels Aug 3, 2023
@alexgarel
Copy link
Member Author

I'm speaking about the pen icon:

image

I would replace it with a "check mark" icon. Obviously when you click you can still edit it.

@monsieurtanuki
Copy link
Contributor

@alexgarel Understood: basically, when the data is entered, the background goes from grey to green, and the icon should change too, from "edit" to "check".

@monsieurtanuki
Copy link
Contributor

@g123k Still working on it? I have a one line fix for this one.

@M123-dev
Copy link
Member

Does not look like it @monsieurtanuki guess there will also be some re-design here in the new ui, if you think its a quick fix I'd say feel free to change it, that small think is bothering me for some time now 😆

@g123k g123k removed their assignment Sep 18, 2023
@g123k
Copy link
Collaborator

g123k commented Sep 18, 2023

I forgot about this one actually, yes you can edit it, it's not part of the redesign.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.
Development

Successfully merging a pull request may close this issue.

5 participants