Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] A TestFlight build is created for each commit 🤯 #4347

Closed
g123k opened this issue Jul 21, 2023 · 7 comments
Closed

[CI] A TestFlight build is created for each commit 🤯 #4347

g123k opened this issue Jul 21, 2023 · 7 comments
Labels
🐛 bug Something isn't working CI 🍎 iOS iOS specific issues or PRs

Comments

@g123k
Copy link
Collaborator

g123k commented Jul 21, 2023

Hi everyone,

We currently have a GitHub Action that sends each commit from the dev branch to TestFlight.
I'm not sure it is that relevant to send so many builds (and consume so much power for nothing).

Shouldn't we use a manual trigger instead?

Screenshot 2023-07-21 at 14 05 51
@g123k g123k added the CI label Jul 21, 2023
@M123-dev
Copy link
Member

Yes, we wanted it like this for testing. Now that we have waldo it is probably not needed anymore

If we decide against it its just removing

.github/workflows/internal-release.yml

it calls the release for the play and app store

@g123k
Copy link
Collaborator Author

g123k commented Jul 27, 2023

Is-it OK for you @teolemon that we disable this?

@teolemon
Copy link
Member

  • I don't understand why Android internal would still be on every commit and Apple TestFlight wouldn't.
  • Anyway, if we end up disabling this, We need a button to trigger the action for a TestFlight release

@g123k
Copy link
Collaborator Author

g123k commented Jul 27, 2023

  • I don't understand why Android internal would still be on every commit and Apple TestFlight wouldn't.

The idea is to remove both.
This is an abnormal behavior to send every commit on dev to the stores.

  • Anyway, if we end up disabling this, We need a button to trigger the action for a TestFlight release

It would just consist of launching manually the same action

@M123-dev
Copy link
Member

A month ago I would have said that we could just use release please for that

but now F-Droid is linked to it so every new release means a public release on F-Droid no way to publish them on a later date

@teolemon teolemon added the 🍎 iOS iOS specific issues or PRs label Apr 8, 2024
@teolemon teolemon added the 🐛 bug Something isn't working label Apr 16, 2024
@g123k
Copy link
Collaborator Author

g123k commented Apr 16, 2024

Mmm, seems OK now, isn't it?

@teolemon
Copy link
Member

Yes we can close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working CI 🍎 iOS iOS specific issues or PRs
Development

No branches or pull requests

3 participants