Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KP details: no SafeArea and weird iOS behavior #4460

Closed
g123k opened this issue Aug 6, 2023 · 2 comments · Fixed by #4514
Closed

KP details: no SafeArea and weird iOS behavior #4460

g123k opened this issue Aug 6, 2023 · 2 comments · Fixed by #4514
Labels
🐛 bug Something isn't working good first issue Good for newcomers 🍎 iOS iOS specific issues or PRs 📖 Knowledge panels

Comments

@g123k
Copy link
Collaborator

g123k commented Aug 6, 2023

Hi everyone,

When we click on a KP detail (such as the NutriScore, Ecoscore…), there is no extra padding at the bottom.
The better implementation here would be the same as the Website button (cf #4349).

Also on iOS, there is the bouncing effect, but it crops the page weirdly, as you can see in this demo: https://github.com/openfoodfacts/smooth-app/assets/246838/0f7f7531-38e0-42b3-a5d4-09e17c19c897

Part of

@g123k g123k added 🐛 bug Something isn't working good first issue Good for newcomers 🍎 iOS iOS specific issues or PRs 📖 Knowledge panels labels Aug 6, 2023
@g123k
Copy link
Collaborator Author

g123k commented Aug 6, 2023

@teolemon There is a Pull-to-refresh here, any reason for that?

@teolemon
Copy link
Member

teolemon commented Aug 6, 2023

To refresh the product page, if needed. Editing refresh and rescan leave some edge cases where a manual refresh might still be necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working good first issue Good for newcomers 🍎 iOS iOS specific issues or PRs 📖 Knowledge panels
Development

Successfully merging a pull request may close this issue.

2 participants