Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The email to reset a password is always in English #4503

Closed
g123k opened this issue Aug 10, 2023 · 7 comments
Closed

The email to reset a password is always in English #4503

g123k opened this issue Aug 10, 2023 · 7 comments
Assignees
Labels
Blocked on Dart API Issues that are blocked on the dart api implementation 🐛 bug Something isn't working fixed ? This bug might already be fixed. If so, close it. 🎯 P1 👥 User management Account login, signup, signout

Comments

@g123k
Copy link
Collaborator

g123k commented Aug 10, 2023

Hi everyone,

The Dart package doesn't allow selecting the country/language, hence always sending the email to reset the password in English.
Screenshot 2023-08-10 at 10 16 15

@g123k g123k added 🐛 bug Something isn't working 👥 User management Account login, signup, signout Blocked on Dart API Issues that are blocked on the dart api implementation labels Aug 10, 2023
@g123k g123k self-assigned this Aug 10, 2023
@g123k
Copy link
Collaborator Author

g123k commented Aug 10, 2023

In progress, waiting for openfoodfacts/openfoodfacts-dart#781 to be merged and a new version released

@monsieurtanuki
Copy link
Contributor

In progress, waiting for openfoodfacts/openfoodfacts-dart#781 to be merged and a new version released

Done on the off-dart side.

@g123k
Copy link
Collaborator Author

g123k commented Aug 14, 2023

In progress, waiting for openfoodfacts/openfoodfacts-dart#781 to be merged and a new version released

Done on the off-dart side.

Thanks a lot @monsieurtanuki

@teolemon
Copy link
Member

@g123k I believe this is fixed ?

@teolemon teolemon added the fixed ? This bug might already be fixed. If so, close it. label Aug 26, 2023
@monsieurtanuki
Copy link
Contributor

@teolemon Waiting for #4573 to be approved and merged.

@teolemon
Copy link
Member

Done @monsieurtanuki

@monsieurtanuki
Copy link
Contributor

Thank you @teolemon for the review.

This issue is fixed now:

  • the country+language is passed to the server (a localized email is then expected) (coded by @g123k)
  • we check the returned message in all languages (coded by @monsieurtanuki)

I think we're done now.
For the record in my tests I never managed to get an email (in English or localized), but maybe it was a temporary error on the server (or too much retries).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocked on Dart API Issues that are blocked on the dart api implementation 🐛 bug Something isn't working fixed ? This bug might already be fixed. If so, close it. 🎯 P1 👥 User management Account login, signup, signout
Development

No branches or pull requests

3 participants