Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine FastTrack behavior on edge cases #4595

Open
teolemon opened this issue Aug 24, 2023 · 4 comments
Open

Refine FastTrack behavior on edge cases #4595

teolemon opened this issue Aug 24, 2023 · 4 comments
Labels
P4 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.

Comments

@teolemon
Copy link
Member

teolemon commented Aug 24, 2023

What

  • We display FastTrack in cases we should not
  • In that case, we have the scores, we seem to have the ingredients, we might miss minor variables for the Eco-Score
  • We need to list reports of FastTrack appearing randomly, and handle them properly.

Which products

  • Products with no ingredient list
  • Products with no nutrition facts

Alcohol

1. Unprocessed products that comprise a single ingredient or category of ingredients (such as fresh
fruits or vegetables, cut raw meat, honey, etc.)
2. Processed products where the only processing they have been subjected to is maturing and that
comprise a single ingredient or category of ingredients Note: here the products in question are mainly
meat products
3. Waters intended for human consumption, including those where the only added ingredients are
carbon dioxide and/or flavourings
4. Herbs, spices or mixtures thereof
5. Salt and salt substitutes
6. Table top sweeteners
7. Products covered by Directive 1999/4/EC of the European Parliament and of the Council of 22
February 1999 relating to coffee extracts and chicory extracts, whole or milled coffee beans, and
whole or milled decaffeinated coffee beans
8. Herbal and fruit infusions, tea, decaffeinated tea, instant or soluble tea or tea extract, decaffeinated
instant or soluble tea or tea extract, which do not contain other added ingredients than flavourings
which do not modify the nutritional value of the tea
9. Fermented vinegars and substitutes for vinegar, including those where the only added ingredients
are flavourings
10. Flavourings
11. Food additives
12. Processing aids
13. Food enzymes
14. Gelatine
15. Jam setting compounds
16. Yeasts
17. Chewing gums
18. Food in packaging or containers the largest surface of which has an area of less than 25 cm²
19. Food, including handcrafted food, directly supplied by the manufacturer of small quantities of
products to the final consumer or to local retail establishments directly supplying the final consumer

Part of

Screenshot/Mockup/Before-After

image

@monsieurtanuki
Copy link
Contributor

@teolemon Perhaps we could just let the server tell us something like "nutriscore: not applicable for that category" (we already know that), detect that and not display the fast-track in those cases.

@monsieurtanuki
Copy link
Contributor

@teolemon That goes even beyond the fast track button: looks what happens if you click on a "not applicable nutriscore" button...
There's a discrepancy between the nutriscore as an attribute (nutriscore-not-applicable) and the knowledge panel ("actions":["add_nutrition_facts"])
=> server fix needed

A possible solution at the Smoothie level would be to make the nutriscore button not clickable (and have no forward arrow) if the nutriscore is "not applicable", but that would prevent users from getting info about why the nutriscore is not applicable (the explanation is not available from the server anyway for the moment).

product page nutriscore page
Screenshot_2023-08-25-12-45-47 Screenshot_2023-08-25-12-45-53

@monsieurtanuki
Copy link
Contributor

What is implemented in #4599: we don't display the fast-track button if the nutriscore or the ecoscore are computed as "not applicable" by the server.

Are there be other typical cases to take care of beyond those "not applicable" scores?

@teolemon
Copy link
Member Author

teolemon commented Aug 27, 2023

  • products that should really be on Open Beauty Facts, Open Pet Food Facts, Open Products Facts, and that are just categorized as such.
  • We'd have to check if the scores not applicable are correctly sent by the server in those cases.

@monsieurtanuki monsieurtanuki removed their assignment Oct 27, 2023
@teolemon teolemon added the P4 label Dec 8, 2023
@teolemon teolemon removed the 🐛 bug Something isn't working label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.
Projects
Status: No status
Status: 💬 To discuss and validate
Development

No branches or pull requests

2 participants