Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the top bar transparent in the first screen of the onboarding #4606

Closed
Tracked by #4614
teolemon opened this issue Aug 28, 2023 · 5 comments · Fixed by #4615
Closed
Tracked by #4614

Make the top bar transparent in the first screen of the onboarding #4606

teolemon opened this issue Aug 28, 2023 · 5 comments · Fixed by #4615
Assignees
Labels
🐛 bug Something isn't working 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…

Comments

@teolemon
Copy link
Member

What

  • Make the top bar transparent in the first screen of the onboarding, just like the others
    image
@teolemon teolemon added 🐛 bug Something isn't working 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… labels Aug 28, 2023
@bishalbera
Copy link

@teolemon Hey can I work on this issue?

@monsieurtanuki
Copy link
Contributor

Sure @bishalbera!

I'm sorry I had to pre-process that issue, but I needed to understand it: I think you have to use a SmoothScaffold in reinvention_page.dart (cf. welcome_page.dart)

@bishalbera
Copy link

bishalbera commented Sep 1, 2023

@monsieurtanuki thanks for your info.. when I tried to run the app on Android I found that topbar is already transparent in the welcome_page.dart also when I on the device preview it seems not transparent again. Here's the pics
WhatsApp Image 2023-09-01 at 09 31 33

WhatsApp Image 2023-09-01 at 09 31 33

@monsieurtanuki
Copy link
Contributor

@bishalbera I think I can explain that:

  • I believe that the issue is on ios only
  • I know that device_preview is flawed - for instance the SafeArea in your second screenshot is respected at the device level, but not at the virtual device level (which is what we would need)

In this particular case, I think you need a mac in order to control the top bar display.
I don't recommend you buy a mac just for that issue though!
Is that ok if I reassign this issue to me? Will take me 5 minutes to fix and more specifically to take relevant screenshots, on my mac + ios emulator.

@bishalbera
Copy link

@monsieurtanuki ya sure please reassign it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Development

Successfully merging a pull request may close this issue.

3 participants