New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some SVGs are visually incorrect #4617

Open

g123k opened this issue Sep 2, 2023 · 1 comment

Labels

Collaborator

g123k commented Sep 2, 2023

Hi everyone,

As part of a redesign process, I have noticed that some SVGs in the app look really bad:

nutriscore-not-applicable.svg

Screenshot 2023-09-02 at 20 40 51

nutriscore-unknown.svg

Screenshot 2023-09-02 at 20 41 11

nature-et-progres.svg

Screenshot 2023-09-02 at 20 41 58

haute-valeur-environementale.svg

Screenshot 2023-09-02 at 20 42 28

ecoscore-not-applicable.svg

Screenshot 2023-09-02 at 20 42 58

bleu-blanc-coeur.svg

Screenshot 2023-09-02 at 20 43 23

ab-agriculture-biologique.svg

Screenshot 2023-09-02 at 20 43 41

g123k added 🐛 bug asset cache labels

Contributor

monsieurtanuki commented Sep 3, 2023

@g123k Those are local cache versions.

They are optimized because

they are temporary icons while their server counterparts are being downloaded, and displaying "simplified" icons is much faster
they are not supposed to be displayed big
at the time, we displayed tons of SVGs in the same screen, and processing all those SVGs slowed a lot the display.

Feel free to replace the local cache versions with the pixel perfect server versions.

monsieurtanuki mentioned this issue

fix: 4630 - no more sentry cluttering when downloading svg without internet #4642

Merged

teolemon removed the 🐛 bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment