Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try SegmentedButtons instead of our horrible "importance" radio buttons #4633

Closed
monsieurtanuki opened this issue Sep 14, 2023 · 19 comments
Closed
Assignees
Labels
✨ enhancement New feature or request

Comments

@monsieurtanuki
Copy link
Contributor

Problem

We all agree that the "importance" preferences look ugly.

Proposed solution

We could use the standard SegmentedButton instead.
Can't be worse than the current implementation anyway.

Mockups

Capture d’écran 2023-09-14 à 09 46 48
Capture d’écran 2023-09-14 à 09 46 13

@monsieurtanuki monsieurtanuki added the ✨ enhancement New feature or request label Sep 14, 2023
@harhitosw
Copy link

@monsieurtanuki I am new to this repository can I take up this issue and fix the UI with the suggested solution ?

@monsieurtanuki
Copy link
Contributor Author

Welcome @harhitosw!
You may have a look at it, but I'm afraid that won't lead to something very glamourous. I've tested a bit yesterday and that didn't look that good: each label is definitely too long, and that doesn't fit into a screen - especially mine.
Before actually coding in this app, please share some screenshots of 4 labels ('Not important', 'Important', 'Very important' and 'Mandatory') displayed as a SegmentedButton, from just a test app, on a smartphone (or emulator).

@harhitosw
Copy link

Welcome @harhitosw! You may have a look at it, but I'm afraid that won't lead to something very glamourous. I've tested a bit yesterday and that didn't look that good: each label is definitely too long, and that doesn't fit into a screen - especially mine. Before actually coding in this app, please share some screenshots of 4 labels ('Not important', 'Important', 'Very important' and 'Mandatory') displayed as a SegmentedButton, from just a test app, on a smartphone (or emulator).

yeah sure I should check that and share the screenshots here than maybe we can decide what we can do with that issue !

@harhitosw
Copy link

harhitosw commented Sep 15, 2023

@monsieurtanuki I am thinking of using MediaQuery for changing the font size in this box , we can play around with sizes and see , if you have anything else in mind please let me know :)

@monsieurtanuki
Copy link
Contributor Author

@monsieurtanuki I am thinking of using MediaQuery for changing the font size in this box , we can play around with sizes and see , if you have anything else in mind please let me know :)

Use AutoSizeText instead, probably with maxLines: 2.

@monsieurtanuki
Copy link
Contributor Author

The more I think about it the more I think we are in the wrong direction altogether. Of course it would be nice to be able to change the preference in one click.

But:

  1. all labels (as clickable) cannot fit into one line (especially in all languages)
  2. we don't really need that "only one click" feature. To be confirmed: how many people change their food preferences at least once, or twice, or several times? How grumpy would they be if they had to click twice instead of once, and how often would that happen?

We would probably be better off with just one label and buttons to go up or down.

Something like:
(-) not important [+]
[-] important [+]
[-] very important [+]
[-] mandatory (+)

Or something like:
not important [+] [+] [+]
[-] important [+] [+]
[-] [-] very important [+]
[-] [-] [-] mandatory

Or a simple drop-down menu...

@harhitosw It's a UI/UX question rather than just "put segmentedbutton and we're done". We've all agreed for years that the current implementation stinks, but it's a low priority issue in a capital feature that is used only once (or never).

@harhitosw
Copy link

harhitosw commented Sep 16, 2023

@monsieurtanuki I completely agree to what you say , but at the same time I feel that this UI buttons look ugly and we need to fix it somehow . Since yesterday I was trying to fix those buttons but no avail , I wasn't able to do that maybe we can have a simple dropdown menu , as far as my opinion is concerned the drop-down menu would be the most suitable option . We can have that drop-down menu with little animation (if we find one suitable animation) . Yeah so maybe we can have a drop-down menu and fix the issue moreover this looks simpler and it won't take much time or efforts. Still you can suggest what more we can do , else I may take-up this and fix the issue.

@monsieurtanuki
Copy link
Contributor Author

@harhitosw For the moment please just share screenshots of each possibility we mentioned - including the current ugly version.
Even regardless of the app: just "not important", "important", "very important" and "mandatory" as options.
This issue has a low priority, and we survived with the ugly UI anyway. I started this issue just because I hoped SegmentedButtons could help as a quick fix - but it's probably not the case.
No PR for the moment.

@M123-dev
Copy link
Member

That has gotten a somewhat historical issue by now (not THIS issue but the general UI of the food preferences)

We tried a bunch of design ideas without finding a one which all of us are happy about, so yeah we just have to first try some maybe ugly ux things, ui and logic can be added later

@monsieurtanuki
Copy link
Contributor Author

For what it's worth, my personal choice would be:
(-) not important [+]
[-] important [+]
[-] very important [+]
[-] mandatory (+)

@harhitosw
Copy link

Hi @monsieurtanuki ! we discussed I have tried some options for the buttons which we discussed you may a look at them and we may proceed wisely
1. I tried the segmented button with Fitted Box so that we fit in the text .
image
2. Also I tried to implement this using Auto Size text which did not make a difference and looks like this
image
3. I have also tried the most preferred option we can have and also your personal choice
image
**Please let me know anything else we can try and I will be trying that too , moreover I am bit optimistic about the UX issues somehow we can solve them only thing is that we need to try out more possibilities :) **

@g123k
Copy link
Collaborator

g123k commented Oct 1, 2023

Actually, we will use a totally different way to ask for food preferences (without this scale).
So please, don't implement it, it won't be final implementation.

@harhitosw
Copy link

harhitosw commented Oct 2, 2023

Okay that's also fine this wasn't for implementation @monsieurtanuki and I wanted to check few things that's why I did it , anyways do we have discussed or do we have any idea of what we want to do to replace this scale ?

@monsieurtanuki
Copy link
Contributor Author

Sorry about that @harhitosw, there's been a collision between this issue and a recent global UI/UX refactoring.
For the record I'm not convinced by the new UI/UX suggestion either.
There's no issue for the new UI/UX suggestion yet.

@harhitosw
Copy link

Okay I see it, that's fine @monsieurtanuki can you suggest me any new issues that I can work on ? I will be glad to work in them and contribute :)

@harhitosw
Copy link

Thank You @monsieurtanuki

@g123k
Copy link
Collaborator

g123k commented Oct 2, 2023

Sorry about that @harhitosw, there's been a collision between this issue and a recent global UI/UX refactoring. For the record I'm not convinced by the new UI/UX suggestion either. There's no issue for the new UI/UX suggestion yet.

For the new implementation, definitely, it will be a wizard-like screen.
We will try as soon as tomorrow another variant with fewer questions and in another order.
I try to publish info about it when we're sure of the final impl

@monsieurtanuki
Copy link
Contributor Author

@harhitosw If you're looking for very easy / highest priority issues to solve, please have a look at #4692 #4693 #4694.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Development

No branches or pull requests

4 participants