Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Stores" field should not show a ProgressBar #4669

Closed
g123k opened this issue Sep 29, 2023 · 2 comments · Fixed by #4678
Closed

"Stores" field should not show a ProgressBar #4669

g123k opened this issue Sep 29, 2023 · 2 comments · Fixed by #4678
Assignees
@WildOrangutan
Labels
🐛 bug Something isn't working ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users good first issue Good for newcomers

Comments

@g123k
Copy link
Collaborator

g123k commented Sep 29, 2023 •
edited by teolemon
Loading

Hi everyone,

When we edit a product, we can add Stores.
However, we don't have (yet) an auto-completion for this field.
But even, we should a ProgressBar for nothing, as we don't have any.

So the fix here is to remove this mechanism for the particular case of Stores.

Video

RPReplay_Final1696016669.MP4
@g123k g123k added 🐛 bug Something isn't working good first issue Good for newcomers ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users labels Sep 29, 2023
@WildOrangutan
Copy link
Contributor

I can work on this :)

@g123k
Copy link
Collaborator Author

g123k commented Sep 30, 2023

I can work on this :)

Ok, but just ask for one issue at a time, please

WildOrangutan added a commit to WildOrangutan/smooth-app that referenced this issue Sep 30, 2023
@WildOrangutan
fix: Loading when no suggestions (openfoodfacts#4669)
acebdd8 
Loading spinner was showing, even if there were no loading or
suggestions available.

Fixes openfoodfacts#4669
@WildOrangutan WildOrangutan mentioned this issue Sep 30, 2023
Merged
monsieurtanuki pushed a commit that referenced this issue Oct 2, 2023
@WildOrangutan
fix: "Stores" field to not show loading spinner (#4669) (#4678)
6fb5e18 
* fix: Loading when no suggestions (#4669)

Loading spinner was showing, even if there were no loading or
suggestions available.

Fixes #4669

* refactor: Simple input text field loading

Also fixes crash and properly disables loading, when try-catch block throws exception.
@github-actions github-actions bot mentioned this issue Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WildOrangutan WildOrangutan

Labels
🐛 bug Something isn't working ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users good first issue Good for newcomers
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: "Stores" field to not show loading spinner (#4669) WildOrangutan/smooth-app
2 participants
@g123k @WildOrangutan