Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of the OCR page UI/UX #5047

Open
monsieurtanuki opened this issue Feb 6, 2024 · 9 comments
Open

Refactoring of the OCR page UI/UX #5047

monsieurtanuki opened this issue Feb 6, 2024 · 9 comments
Labels
🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. OCR page

Comments

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented Feb 6, 2024

But for the UI: Having the buttons directly above the Image isn't great. Especially for the ones which tend to are very stretched.

Maybe we should align them to the top,
Maybe move the image above them
Make the buttons (which are of lower priority?) a drop down

Any suggestions @g123k @teolemon @AshAman999

Originally posted by @M123-dev in #5027 (comment)

@monsieurtanuki
Copy link
Contributor Author

We're talking about EditOcrPage. The current layout is a stack of 2 layers:

  • a full screen image (somehow centered)
  • on top of the image, buttons and text fields, bottom-aligned

Perhaps we could find inspiration in the "standard photo page", not using a stacks but a column, with the image using the remaining space on top? In many cases that wouldn't be a problem as text is displayed horizontally.

OCR page with photo standard photo page
Screenshot_1706636742 Screenshot_1704118168

@teolemon
Copy link
Member

teolemon commented Feb 7, 2024

Eventually, we're going to have a "Report image" button, in conjonction with https://github.com/openfoodfacts/nutripatrol/issues

@monsieurtanuki
Copy link
Contributor Author

@teolemon @M123-dev My point here is to have #5027 merged: I've just added a couple of buttons, as required by #5020.
Now I feel like I'm stuck between the past (the UX/UI already stunk before I added the buttons) and the future (some day we may add another button).
Adding to that the fact that we have a limited number of code reviewers each with a limited time, moving forward is getting difficult.

@g123k
Copy link
Collaborator

g123k commented Feb 13, 2024

Hello,

Here's a screen I made in 5 minutes, but where I try to address the hierarchy problem.
We guide the user to :

  1. Select a language,
  2. Then the ingredients
  3. And optionally the photo.

The actions for the photo shouldn't be on this screen: that's not its role.

iPhone 13

As I have said, this is just a quick mockup, so feel free to add your suggestions.

@g123k
Copy link
Collaborator

g123k commented Feb 13, 2024

Or even a simpler one:

iPhone 13

@monsieurtanuki
Copy link
Contributor Author

@g123k I believe the point of that screen was the OCR - or at least photo upload. Therefore something more like that:

  1. language select
  2. photo upload
  3. OCR
  4. manual ingredient text fix if relevant

That said, in your screenshots I see a button that would help us: a single "modify photo" button. Instead of our current 4 buttons ("edit", "select an existing photo", "take another one", "unselect"). The "modify photo" button would go to the existing photo manager (screenshot 2 in the OP).
That would fix at least partially the initial issue: "too many buttons on that page". And will give us more space on top of the page to put the picture (instead of stacking a centered picture with many buttons).

@g123k
Copy link
Collaborator

g123k commented Feb 13, 2024

The "Edit picture" button was indeed there to redirect to the other screen, because we have 11 actions:

300913185-9b5df9a2-d31e-498d-89a1-45e251f6b039

And I think that the OCR should be limited to "Extract ingredients": all other actions have no direct link to Ingredients.
The second question is, is the photo more important than the list? (for me, the answer is NO)

@monsieurtanuki
Copy link
Contributor Author

The second question is, is the photo more important than the list? (for me, the answer is NO)

I have no strong opinion on the subject. Except that those are "OCR" pages.
Definitely not the easiest page to design!

@monsieurtanuki
Copy link
Contributor Author

cf. #3975 too.

@teolemon teolemon added the 🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. OCR page
Projects
Status: 💬 To discuss and validate
Development

No branches or pull requests

3 participants