Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

photo dates not visible on mobile, difficult to know the most up-to-date version #5128

Open
Tracked by #5125
monsieurtanuki opened this issue Mar 23, 2024 · 10 comments
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users fixed ? This bug might already be fixed. If so, close it. Supporting data refresh

Comments

@monsieurtanuki
Copy link
Contributor

No description provided.

@monsieurtanuki
Copy link
Contributor Author

@teolemon teolemon added the ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users label Mar 23, 2024
@monsieurtanuki
Copy link
Contributor Author

off-dart v3.5.0 is not public yet, but we can start to play with the uploaded timestamp using a local off-dart up-to-date package.

Of course several options are available regarding dates:

  • sorting pictures by date (which is probably already the case, but it's not visibly obvious)
  • displaying the date on each picture (on top? below with a Text?)
  • specific icon for out-of-date pictures (on top)
  • listing pictures with "last week", "last month", "last year", "older" list subtitles
  • strongly preventing users from using out-of-date pictures when trying to refresh an existing picture

@monsieurtanuki monsieurtanuki self-assigned this Apr 2, 2024
@monsieurtanuki
Copy link
Contributor Author

If we put an extra "wrong!" icon on older images (e.g. more than 1 year old), the order of images gets implicit and the "good" and fresh pictures too.
@teolemon @jusdekiwi Would that be good?

1 2 3
Screenshot_1712135552 Screenshot_1712135561 Screenshot_1712135578

@jusdekiwi
Copy link

Maybe a "warning" icon would be better since old doesn't mean wrong.
Also as shown in your previous message, it seems like clicking on the old images would delete them. That's not what we want, is it?
Last thing, would it be possible to tell if one "old" image is obsolete or? Because it would be useful to be able to tell that the product has not changed. Otherwise we would have to take new pictures all the time.
Thank you for your work anyway!! :)

@monsieurtanuki
Copy link
Contributor Author

@jusdekiwi It's just a matter of icon: a "warning" icon would be more appropriate indeed. No specific action is intended for the moment anyway (i.e. no "image deleting").

This issue is only about upload timestamps. There is no obsolete flag triggered by a power-user or a producer in Smoothie.
The only "obsolete" flag we use (and actually we currently don't) is "OBSOLETE_NUTRITION_IMAGE", that is true if states contain either 'en:nutrition-photo-to-be-selected' or 'en:photos-to-be-uploaded'. Doesn't look very reliable IMHO.

Perhaps we could work on the "upload timestamp" aspect only, then in another issue be more specific about "obsolete" images if needed.

@teolemon
Copy link
Member

teolemon commented Apr 4, 2024

  • I would add the explicit date on the photo, like we do on the web.
  • I would avoid radius on photos if they are not spaced. Edge to edge without radius if they are stuck together (like the Google Photos pattern), or with a radius, and clear padding.
  • I would take the occasion to allow multi-select on long-press for image moderation (no other usecase) on the whole gallery
  • We could add moderator only features like moving images to another product, or image deletion
  • We should add support for image reporting using Nutri-Patrol (first as a deeplink to the Nutri-Patrol using a web-view, then using the API) for everyone
  • We should refrain from using icons only to indicate stale status. The idea of separating image by their quarter, with headers could be interesting (Q1-2024, Q2-2019…) and more value adding

Web reference

image

Old mockup I did (without headers)

image

@jusdekiwi
Copy link

@monsieurtanuki on the webapp it's kind of okay since i can see the dates by hovering the pictures with my cursor.
However, on the mobile app, I can't see them.
What I would like is having a visible timestamp over or under the pictures uploaded in the mobile app when selected an existing picture. I've made an example below. I am not sure about the warnings, maybe we would need more opinions of contributors.
image

@teolemon
Copy link
Member

teolemon commented Apr 4, 2024

image

@monsieurtanuki
Copy link
Contributor Author

@jusdekiwi Something like that?
Screenshot_1712310068

@jusdekiwi
Copy link

Yeah, that would be really good. I'm not sure about the exclamation marks for the old ones though. Maybe a light red/pink background for the text would be more obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users fixed ? This bug might already be fixed. If so, close it. Supporting data refresh
Projects
Status: 💬 To discuss and validate
Development

No branches or pull requests

3 participants