Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache and Nutri-score v2 #5168

Closed
g123k opened this issue Apr 19, 2024 · 1 comment · Fixed by #5170
Closed

Cache and Nutri-score v2 #5168

g123k opened this issue Apr 19, 2024 · 1 comment · Fixed by #5170

Comments

@g123k
Copy link
Collaborator

g123k commented Apr 19, 2024

Hi everyone,

I will soon publish the PR to test the content with the new Nutri-score.
That's why we have to cache the different versions of the logo…

But the V2 has a text at the bottom, meaning, that we have now X logos x Y languages.
What should we do for the cache?

  • Store only the EN version?
  • Store all versions?
@teolemon
Copy link
Member

@g123k @stephanegigandet we currently only have en and fr.
Most likely, we will load on the server de, nl, es, PT as well
The question is still open for other languages, if SpF will provide an official translation or if we want to make our own, to make the new score more approachable.
The other options are to use the new English logo for all those, or the old logo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants