Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The wrong picture is deleted when deleting a picture in a "not-default" language on the app #5247

Closed
jusdekiwi opened this issue May 13, 2024 · 0 comments · Fixed by #5266
Closed

Comments

@jusdekiwi
Copy link

What

  • The wrong picture is deleted when deleting a picture in a "not-default" language.

Steps to reproduce the behaviour

  1. Go to a product having a nutrition fact picture for different languages ;
  2. Go to 'Edit product' > 'Photos' > 'Nutrition' ;
  3. Click on the language dropdown menu: you should see language 1 and language 2 checked.
  4. You want to check the picture for language 2 -> you click on language 2.
  5. A new picture (in language 2) is now displayed. Let's say you want to delete it because it is wrong for some reason ;
  6. You click on 'unselect photo'
  7. You're then redirected to the 'photos' menu but you can quickly realise that the picture in langage 2 has not been removed. However, the picture in language 1, which you didn't want to delete, was deleted! So the wrong picture was deleted.

Expected behavior

  • If I have selected 'language 2' when viewing a nutrition facts picture, and if i click on "unselect photo", then the corresponding picture should be removed, NOT another photo in the default language.

Smartphone model

  • Device: Redmi Note 7
  • OS: Lineage lavender (Android like)
  • App Version: 4.13.1

Additional context

  • The same thing happens with ingredients pictures so I assume the bug exists for all the categories of pictures.
  • I've finally manage to replace the photo in language 2 by:
    • selecting language 1
    • adding a new photo for language 1 (in language 2), which I should not do
    • selecting language 2
    • adding a new photo for language 2 (selecting the one I previously added for language 1)
    • selecting language 1
    • changing the picture back to the original one, which was correct in the first place
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants