Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Crowdin SDK #5310

Closed
g123k opened this issue May 30, 2024 · 2 comments
Closed

Issue with Crowdin SDK #5310

g123k opened this issue May 30, 2024 · 2 comments
Labels

Comments

@g123k
Copy link
Collaborator

g123k commented May 30, 2024

Hi everyone,

In the app, for the Nutri-score Guide, we use the Crowdin SDK to be able to fetch the latest translations.
We initially used this mechanism to speed up the deployment (and be able to fix potential erros).

However, there is a major issue with the Flutter SDK: it never updates the translation (yes, yes! The main feature of the SDK!).
After digging a little bit, they don't use their API correctly.
Instead of https://distributions.crowdin.net/{distribution_hash}/content/{path_to_file}?timestamp={timestamp_from_manifest}, they use https://distributions.crowdin.net/{distribution_hash}/content/{path_to_file} (= the timestamp query is missing).

Also, we were forced to fork their repo, because of uni_links (incompatible with our Deep links mechanism).
The good news however, is that the latest version of the SDK fixes this.

So now, we have multiple choices:

  • Re-sync the fork and patch the API url
  • Create a PR on the official repo, but without any guarantee it will be accepted/ready on time
  • Ditch the dependency and manually call the API in the app
  • Hard-code all translations in the current mechanism (but it means losing the auto-update feature)

Also, please bear in mind, that the content is still not validated (and we don't know if it will even be…).

@g123k g123k added the crowdin label May 30, 2024
@monsieurtanuki
Copy link
Contributor

I'm not familiar with Crowdin or uni_links, but AFAIU I would suggest 2 options in parallel:

  • Re-sync the fork and patch the API url
  • Create a PR on the official repo

@g123k
Copy link
Collaborator Author

g123k commented May 30, 2024

Finally, there is a new plan: the event scheduled next week is postponed.
The content is also validated.

So I will migrate everything in the app translations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants