Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamps in image picker #5323

Closed
teolemon opened this issue Jun 1, 2024 · 2 comments · Fixed by #5333
Closed

Add timestamps in image picker #5323

teolemon opened this issue Jun 1, 2024 · 2 comments · Fixed by #5333

Comments

@teolemon
Copy link
Member

teolemon commented Jun 1, 2024

What

  • Add timestamps in image picker
    image
@monsieurtanuki
Copy link
Contributor

@teolemon I've already read a similar issue. The thing is that we have 2 ways of displaying "all" pictures:

  1. in the product image page, below the 4 main, in columns of 3, and we display the timestamps
  2. in the "pick existing image" page, in columns of 2, and we don't display the timestamps

2 ways to solve this issue:

  1. re-use the same product image list - the one with the timestamps and remove the related dead code
  2. sort of duplicate code in the "pick existing image" page

I have a strong preference for reusing the code that already works.

@monsieurtanuki monsieurtanuki added the good first issue Good for newcomers label Jun 2, 2024
@teolemon
Copy link
Member Author

teolemon commented Jun 2, 2024

Let's de duplicate for the 3 images per row + timestamps 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants