Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a nice screen asking for camera permission #543

Closed
slava-sh opened this issue Aug 26, 2021 · 5 comments
Closed

Add a nice screen asking for camera permission #543

slava-sh opened this issue Aug 26, 2021 · 5 comments
Labels
🐛 bug Something isn't working 🍎 iOS iOS specific issues or PRs permissions 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Milestone

Comments

@slava-sh
Copy link
Member

slava-sh commented Aug 26, 2021

See juliuscanute/qr_code_scanner#345 (comment)

To Reproduce
Steps to reproduce the behavior:

  1. Open the app in the iOS simulator
  2. An uncaught CameraException is thrown

Part of

@slava-sh slava-sh added 🐛 bug Something isn't working 🍎 iOS iOS specific issues or PRs labels Aug 26, 2021
@slava-sh
Copy link
Member Author

As mentioned in the linked issue, we could use something like https://pub.dev/packages/permission_handler to avoid displaying QRView when the permission is not granted. We could show a nice screen explaining how to grant the permission in that case.

@slava-sh slava-sh changed the title qr_code_scanner throws an exception when camera permission is denied on iOS Add a nice screen asking for camera permission Sep 2, 2021
@Piinks
Copy link
Contributor

Piinks commented Sep 2, 2021

@teolemon I'd like to work on this alongside some of the graceful fail states I mentioned today. :)

@teolemon
Copy link
Member

teolemon commented Apr 9, 2022

Little sister was startled by this today, just after onboarding.
image

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented Apr 10, 2022

My remarks:

  1. we don't need videos, do we? Perhaps removing videos from the list of requested permission will make the dialog less intrusive
  2. this looks like a standard title, and I think we can put our own localized labels
  3. how do other apps handle the camera permission dialog?
  4. [Edit: added] During the onboarding we could add a comment "You can scan barcode with your camera; you'll see an authorization dialog for that"

@teolemon teolemon added this to the V1 milestone Apr 11, 2022
@olivierdrouard olivierdrouard moved this from Todo (ready 2 dev) to To discuss and validate in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 11, 2022
@teolemon teolemon added 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… and removed scanning labels May 8, 2022
@teolemon teolemon modified the milestones: V1, V1.1 Jun 18, 2022
@g123k
Copy link
Collaborator

g123k commented Jul 11, 2022

Implemented in the app a few weeks ago

@g123k g123k closed this as completed Jul 11, 2022
Repository owner moved this from To discuss and validate to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🍎 iOS iOS specific issues or PRs permissions 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Development

Successfully merging a pull request may close this issue.

5 participants