Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid build failed #5456

Closed
linsui opened this issue Jul 3, 2024 · 6 comments
Closed

F-Droid build failed #5456

linsui opened this issue Jul 3, 2024 · 6 comments
Assignees

Comments

@linsui
Copy link

linsui commented Jul 3, 2024

What

The scanner found binary at packages/smooth_app/assets/animations/off. I'm not sure what it is. https://gitlab.com/fdroid/fdroiddata/-/jobs/7247663017

Steps to reproduce the behavior

  1. Go to '...'
  2. Click on '....'
  3. See error

Expected behavior

Why

Part of

Screenshot/Mockup/Before-After

Smartphone model

  • Device:
  • OS:
  • App Version:

Additional context

@M123-dev
Copy link
Member

M123-dev commented Jul 3, 2024

cc: @g123k

@g123k
Copy link
Collaborator

g123k commented Jul 3, 2024

What

The scanner found binary at packages/smooth_app/assets/animations/off. I'm not sure what it is. gitlab.com/fdroid/fdroiddata/-/jobs/7247663017

Steps to reproduce the behavior

  1. Go to '...'
  2. Click on '....'
  3. See error

Expected behavior

Why

Part of

Screenshot/Mockup/Before-After

Smartphone model

  • Device:
  • OS:
  • App Version:

Additional context

Hello,

It's a Rive file (the extension doesn't care that much).
I will fix it in the next release, but it's totally OK for this one

@linsui
Copy link
Author

linsui commented Jul 3, 2024

Thanks, that's OK. :)

@linsui linsui closed this as completed Jul 3, 2024
@licaon-kter
Copy link

licaon-kter commented Sep 26, 2024

so I don't open a new one:

2024-09-26 08:37:30,240 ERROR: Found dependency file without lock at packages/app_store/apple_app_store/pubspec.yaml
2024-09-26 08:37:30,241 ERROR: Found dependency file without lock at packages/app_store/shared/pubspec.yaml
2024-09-26 08:37:30,242 ERROR: Found dependency file without lock at packages/app_store/uri_store/pubspec.yaml
2024-09-26 08:37:30,243 ERROR: Found dependency file without lock at packages/app_store/google_play/pubspec.yaml
2024-09-26 08:37:31,847 ERROR: Found dependency file without lock at packages/scanner/zxing/pubspec.yaml
2024-09-26 08:37:31,848 ERROR: Found dependency file without lock at packages/scanner/shared/pubspec.yaml

trying to build 4.16.0

are all these packages needed? If so, please add their lock files

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/044884b10212c82af758c522ad152f8c0a3494f0

@M123-dev M123-dev reopened this Sep 26, 2024
@g123k g123k self-assigned this Sep 27, 2024
@g123k
Copy link
Collaborator

g123k commented Sep 27, 2024

so I don't open a new one:

2024-09-26 08:37:30,240 ERROR: Found dependency file without lock at packages/app_store/apple_app_store/pubspec.yaml
2024-09-26 08:37:30,241 ERROR: Found dependency file without lock at packages/app_store/shared/pubspec.yaml
2024-09-26 08:37:30,242 ERROR: Found dependency file without lock at packages/app_store/uri_store/pubspec.yaml
2024-09-26 08:37:30,243 ERROR: Found dependency file without lock at packages/app_store/google_play/pubspec.yaml
2024-09-26 08:37:31,847 ERROR: Found dependency file without lock at packages/scanner/zxing/pubspec.yaml
2024-09-26 08:37:31,848 ERROR: Found dependency file without lock at packages/scanner/shared/pubspec.yaml

trying to build 4.16.0

are all these packages needed? If so, please add their lock files

/LE: fyi gitlab.com/fdroid/fdroiddata/-/commit/044884b10212c82af758c522ad152f8c0a3494f0

@licaon-kter
In the Dart/Flutter doc, libraries should not commit their pubspec.lock, so that's a normal behavior.
https://dart.dev/guides/libraries/private-files#pubspeclock

How can we ask the F-Droid's CI to ignore them?

@linsui
Copy link
Author

linsui commented Oct 14, 2024

Fixed, thanks!

@linsui linsui closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants