Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing birthday cake for new products #5647

Open
monsieurtanuki opened this issue Sep 28, 2024 · 6 comments · May be fixed by #5651
Open

Missing birthday cake for new products #5647

monsieurtanuki opened this issue Sep 28, 2024 · 6 comments · May be fixed by #5651
Assignees
@thedevyash
Labels
illustrations Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.

Comments

@monsieurtanuki
Copy link
Contributor

What

  • We used to display a birthday cake for new products, in order to suggest excitement I guess.
  • The birthday cake isn't displayed anymore, and there are error logs.

Steps to reproduce the behavior

  1. Go to the app
  2. Search for a very unusual barcode like 123123123123
  3. As the product doesn't exist, you'll see a "Hey, it's a new product!" dialog.
  4. In this dialog you don't see a birthday cake, and logs say that the birthday cake is missing

Expected behavior

  • A birthday cake
  • or no birthday cake and no error logs
  • The integration of OxF demands other improvements, like the selection of the product type, but that's another story.

Screenshot/Mockup/Before-After

Screenshot_1727533893

Additional context

E/flutter ( 5795): [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Unable to load asset: "assets/onboarding/birthday-cake.svg".
E/flutter ( 5795): The asset does not exist or has empty data.
E/flutter ( 5795): #0      PlatformAssetBundle.load.<anonymous closure> (package:flutter/src/services/asset_bundle.dart:327:9)
E/flutter ( 5795): <asynchronous suspension>
E/flutter ( 5795): #1      SvgLoader._load.<anonymous closure> (package:flutter_svg/src/loaders.dart:153:41)
E/flutter ( 5795): <asynchronous suspension>
E/flutter ( 5795): #2      _VectorGraphicWidgetState._loadPicture.<anonymous closure> (package:vector_graphics/src/vector_graphics.dart:355:40)
E/flutter ( 5795): <asynchronous suspension>
E/flutter ( 5795): #3      _VectorGraphicWidgetState._loadPicture.<anonymous closure> (package:vector_graphics/src/vector_graphics.dart:369:13)
E/flutter ( 5795): <asynchronous suspension>
E/flutter ( 5795): #4      _VectorGraphicWidgetState._loadAssetBytes.<anonymous closure> (package:vector_graphics/src/vector_graphics.dart:402:45)
E/flutter ( 5795): <asynchronous suspension>
E/flutter ( 5795):
@teolemon teolemon added Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users. illustrations labels Sep 30, 2024
@thedevyash
Copy link

pls assign this issue to me

@monsieurtanuki
Copy link
Contributor Author

Hi @thedevyash!
Please don't provide any random birthday cake.
We used to have one. I guess you'll find it in the code history.

@thedevyash
Copy link

WhatsApp Image 2024-09-30 at 21 32 17_54ecc9d0
this works?

@monsieurtanuki
Copy link
Contributor Author

this works?

I don't know: where did you find this .svg file?

@thedevyash
Copy link

this works?

I don't know: where did you find this .svg file?

Found this in an old version inside assets/onboarding/

@monsieurtanuki
Copy link
Contributor Author

Ok then, you're ready for PR!

@thedevyash thedevyash linked a pull request Sep 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thedevyash thedevyash

Labels
illustrations Product addition The easier it is to add a product and get Nutri-Score, Eco-Score, the happier the users.
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Status: 💬 To discuss and validate
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Missing birthday cake for new products thedevyash/smooth-app
3 participants
@teolemon @monsieurtanuki @thedevyash