Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New svg files to cache, but without an explicit enough name #5744

Open
monsieurtanuki opened this issue Oct 26, 2024 · 0 comments · May be fixed by #5748
Open

New svg files to cache, but without an explicit enough name #5744

monsieurtanuki opened this issue Oct 26, 2024 · 0 comments · May be fixed by #5748
Assignees

Comments

@monsieurtanuki
Copy link
Contributor

Problem

With the latest AppNewsProvider, we get the following message:
AssetCacheHelper: please download https://raw.githubusercontent.com/openfoodfacts/smooth-app_assets/refs/heads/main/prod/tagline/android/assets/donation_campaign/fr.svg and put it in asset somewhere like [assets/cache/fr.svg, assets/cacheTintable/fr.svg]

Of course we may cache a file called fr.svg, but that would be dangerous if next time another file would bear the same name but from another folder.

Proposed solution

An alternate cache system that would accept cached filenames like donation_campaign__fr.svg

@monsieurtanuki monsieurtanuki self-assigned this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 💬 To discuss and validate
Development

Successfully merging a pull request may close this issue.

1 participant