fix: 5 bugfixes (icons color, better network mgmt / Japanese…) #6127

g123k · 2025-01-04T19:21:06Z

Hi everyone!

Here are 4 fixes:

The icon color in dark mode is now OK (my fault) Dark mode issues are back #6122
When the image in the tagline fails to load, the image container is hidden in all cases (non-vectorial + svg)
Product picture: force a loader when the image is loading
Product gallery: force a loader when the image is loading
A table width can't have a width of 0 Weird table layout in Japanese #6125

codecov-commenter · 2025-01-04T19:24:36Z

Codecov Report

Attention: Patch coverage is 3.33333% with 29 lines in your changes missing coverage. Please review.

Project coverage is 6.38%. Comparing base (4d9c7fc) to head (0d27f7e).
Report is 611 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../lib/cards/product_cards/smooth_product_image.dart	0.00%	10 Missing ⚠️
...p/lib/generic_lib/widgets/images/smooth_image.dart	0.00%	8 Missing ⚠️
...ages/smooth_app/lib/pages/prices/price_button.dart	0.00%	6 Missing ⚠️
...ib/pages/scan/carousel/main_card/scan_tagline.dart	0.00%	3 Missing ⚠️
...l/knowledge_panels/knowledge_panel_table_card.dart	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #6127      +/-   ##
==========================================
- Coverage     9.54%   6.38%   -3.17%     
==========================================
  Files          325     448     +123     
  Lines        16411   25502    +9091     
==========================================
+ Hits          1567    1628      +61     
- Misses       14844   23874    +9030

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

monsieurtanuki

Hi @g123k!
Please have a look at my comments.
Beyond them:

several circular progress indicators at the same time is a good idea to provoke headaches - especially if you're already cursed with low connectivity. A less aggressive OFF specific "wait indicator" may be more appropriate
I still think it would be relevant to cache the home page "support us" logo

monsieurtanuki · 2025-01-05T06:47:43Z

packages/smooth_app/lib/generic_lib/widgets/images/smooth_image.dart

+          frameBuilder: (_, Widget child, int? frame, ____) {
+            if (frame == null) {
+              return const Center(
+                child: CircularProgressIndicator(),


Suggested change

child: CircularProgressIndicator(),

child: CircularProgressIndicator.adaptive(),

Here I'm deliberately forcing the non-adaptive variant, because on iOS, the loader is very small.

packages/smooth_app/lib/cards/product_cards/smooth_product_image.dart

monsieurtanuki · 2025-01-05T06:52:01Z

packages/smooth_app/lib/cards/product_cards/smooth_product_image.dart

+              : null,
+        ),
+        child: const Center(
+          child: CircularProgressIndicator(),


Suggested change

child: CircularProgressIndicator(),

child: CircularProgressIndicator.adaptive(),

Same here.
I'm deliberately forcing the non-adaptive variant, because on iOS, the loader is very small.

monsieurtanuki · 2025-01-05T06:58:59Z

packages/smooth_app/lib/themes/smooth_theme.dart

@@ -69,7 +69,7 @@ class SmoothTheme {
                ? Colors.white
                : myColorScheme.onPrimary,
          ),
-          iconColor: WidgetStateProperty.all<Color>(Colors.white),
+          iconColor: WidgetStateProperty.all<Color>(myColorScheme.onPrimary),


I'm not sure I understand the code here.
The goal is to be able to say: I want this icon in that color (e.g. green or orange for price tags). It's not the same as default light/dark colors. Like here:

True, but the issue is when we don't specify the color.

@raphodn some context we could expose to users a out those colors ?

…ge.dart Co-authored-by: monsieurtanuki <[email protected]>

monsieurtanuki · 2025-01-05T19:26:39Z

Does it work with orange or green price labels?

________________________________ De : Edouard Marquez ***@***.***> Envoyé : dimanche 5 janvier 2025 20:24 À : openfoodfacts/smooth-app ***@***.***> Cc : monsieurtanuki ***@***.***>; Comment ***@***.***> Objet : Re: [openfoodfacts/smooth-app] fix: 5 bugfixes (icons color, better network mgmt / Japanese…) (PR #6127) @g123k commented on this pull request.

________________________________ In packages/smooth_app/lib/themes/smooth_theme.dart<#6127 (comment)>:

@@ -69,7 +69,7 @@ class SmoothTheme {

? Colors.white : myColorScheme.onPrimary, ), - iconColor: WidgetStateProperty.all<Color>(Colors.white), + iconColor: WidgetStateProperty.all<Color>(myColorScheme.onPrimary), True, but the issue is when we don't specify the color. — Reply to this email directly, view it on GitHub<#6127 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACYKI3Y5QRULZT45LH4XC2T2JGBH5AVCNFSM6AAAAABUTLPWZ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMZQHE2TENJTGQ>. You are receiving this because you commented.Message ID: ***@***.***>

g123k · 2025-01-05T19:34:23Z

Does it work with orange or green price labels?
________________________________ De : Edouard Marquez @.> Envoyé : dimanche 5 janvier 2025 20:24 À : openfoodfacts/smooth-app @.> Cc : monsieurtanuki @.>; Comment @.> Objet : Re: [openfoodfacts/smooth-app] fix: 5 bugfixes (icons color, better network mgmt / Japanese…) (PR #6127) @g123k commented on this pull request.
________________________________ In packages/smooth_app/lib/themes/smooth_theme.dart<#6127 (comment)>:
@@ -69,7 +69,7 @@ class SmoothTheme {
? Colors.white : myColorScheme.onPrimary, ), - iconColor: WidgetStateProperty.all(Colors.white), + iconColor: WidgetStateProperty.all(myColorScheme.onPrimary), True, but the issue is when we don't specify the color. — Reply to this email directly, view it on GitHub<#6127 (comment)>, or unsubscribe<github.com/notifications/unsubscribe-auth/ACYKI3Y5QRULZT45LH4XC2T2JGBH5AVCNFSM6AAAAABUTLPWZ6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMZQHE2TENJTGQ>. You are receiving this because you commented.Message ID: @.***>

Ok, this is fixed for prices buttons, where we say icon color = foreground color

monsieurtanuki

The bugs being fixed, let's go!

g123k added 4 commits January 4, 2025 19:41

Fix the elevated button color

7e2f1ce

Scan tagline : when there is an error, hide the image

d3564e8

Better management of errors for the ProductPicture

acc0f42

Force a loader for the gallery

f7daa4f

github-actions bot assigned g123k Jan 4, 2025

github-actions bot added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Jan 4, 2025

g123k linked an issue Jan 4, 2025 that may be closed by this pull request

Dark mode issues are back #6122

Closed

Fix Japanese issue with tables

2ba507f

github-actions bot added 📖 Knowledge panels 📖 Knowledge panels - Table widget labels Jan 4, 2025

g123k changed the title ~~fix: 4 bugfixes including icons color and better network mgmt~~ fix: 5 bugfixes (icons color, better network mgmt / Japanese…) Jan 4, 2025

g123k linked an issue Jan 4, 2025 that may be closed by this pull request

Weird table layout in Japanese #6125

Closed

monsieurtanuki reviewed Jan 5, 2025

View reviewed changes

Update packages/smooth_app/lib/cards/product_cards/smooth_product_ima…

1f861d1

…ge.dart Co-authored-by: monsieurtanuki <[email protected]>

Force a color for Price buttons

0d27f7e

github-actions bot added the Prices label Jan 5, 2025

monsieurtanuki approved these changes Jan 6, 2025

View reviewed changes

teolemon merged commit 43d282a into openfoodfacts:develop Jan 6, 2025
6 checks passed

github-actions bot mentioned this pull request Jan 6, 2025

chore(develop): release 4.18.0 #6057

Open

g123k mentioned this pull request Jan 6, 2025

Issue with the cropper (dark mode) #6086

Closed

g123k deleted the bugfixes branch January 6, 2025 19:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: 5 bugfixes (icons color, better network mgmt / Japanese…) #6127

fix: 5 bugfixes (icons color, better network mgmt / Japanese…) #6127

g123k commented Jan 4, 2025 •

edited

Loading

codecov-commenter commented Jan 4, 2025 •

edited

Loading

monsieurtanuki left a comment

monsieurtanuki Jan 5, 2025

g123k Jan 5, 2025

monsieurtanuki Jan 5, 2025

g123k Jan 5, 2025

monsieurtanuki Jan 5, 2025

g123k Jan 5, 2025

teolemon Jan 5, 2025

monsieurtanuki commented Jan 5, 2025 via email

g123k commented Jan 5, 2025

monsieurtanuki left a comment

	child: CircularProgressIndicator(),
	child: CircularProgressIndicator.adaptive(),

fix: 5 bugfixes (icons color, better network mgmt / Japanese…) #6127

fix: 5 bugfixes (icons color, better network mgmt / Japanese…) #6127

Conversation

g123k commented Jan 4, 2025 • edited Loading

codecov-commenter commented Jan 4, 2025 • edited Loading

Codecov Report

monsieurtanuki left a comment

Choose a reason for hiding this comment

monsieurtanuki Jan 5, 2025

Choose a reason for hiding this comment

g123k Jan 5, 2025

Choose a reason for hiding this comment

monsieurtanuki Jan 5, 2025

Choose a reason for hiding this comment

g123k Jan 5, 2025

Choose a reason for hiding this comment

monsieurtanuki Jan 5, 2025

Choose a reason for hiding this comment

g123k Jan 5, 2025

Choose a reason for hiding this comment

teolemon Jan 5, 2025

Choose a reason for hiding this comment

monsieurtanuki commented Jan 5, 2025 via email

g123k commented Jan 5, 2025

monsieurtanuki left a comment

Choose a reason for hiding this comment

g123k commented Jan 4, 2025 •

edited

Loading

codecov-commenter commented Jan 4, 2025 •

edited

Loading