Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bottom navigation bar sticky (it should be available on every page). #678

Closed
Tracked by #655
monsieurtanuki opened this issue Nov 22, 2021 · 5 comments · Fixed by #679
Closed
Tracked by #655

Make bottom navigation bar sticky (it should be available on every page). #678

monsieurtanuki opened this issue Nov 22, 2021 · 5 comments · Fixed by #679
Assignees
@monsieurtanuki

Comments

@monsieurtanuki
Copy link
Contributor

No description provided.

@monsieurtanuki monsieurtanuki mentioned this issue Nov 22, 2021
Closed
42 tasks
@monsieurtanuki
Copy link
Contributor Author

For the moment there are 3 bottom tabs in the home page: preferences, scan and history. Only one is selected at a given time.
There's no such bottom navigation bar for a product page. But in that case which tab should appear selected? The latest one? None of them?

monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Nov 22, 2021
@monsieurtanuki
feat: openfoodfacts#678 - added bottom navigation bar to product page
30e6841 
The previous bottom navigation bottom bar was refactored, in order to be reused anywhere.
Then it was added to the product page.

Deleted files:
* `home_page.dart`
* `smooth_ui_library/smooth_bottom_navigation_bar.dart`
* `smooth_ui_library/smooth_bottom_navigation_bar_item.dart`

New file:
* `smooth_bottom_navigation_bar.dart`

Impacted files:
* `continuous_scan_page.dart`: added an explicit bottom navigation bar (was implicit through `HomePage`)
* `main.dart`: not using `HomePage` anymore; asking the bottom navigation bar who's the current page instead
* `new_product_page.dart`: added an explicit bottom navigation bar (was not there)
* `product_list_page.dart`: added an explicit bottom navigation bar (was implicit through `HomePage`)
* `product_page.dart`: added an explicit bottom navigation bar (was not there)
* `smooth_ui_library.dart`: removed "UI" version of smooth bottom navigation bar
* `user_preferences.dart`: added a preference for tab index
* `user_preferences_page.dart`: added an explicit bottom navigation bar (was implicit through `HomePage`)
@jasmeet0817
Copy link
Contributor

Oh btw, in case you didn't start working on this, I already have a solution. But if you did, then go for it

@monsieurtanuki
Copy link
Contributor Author

I've already PR'ed (#679). But anyway it took me about one hour - if eventually your solution is to be used instead that wouldn't be such a problem.

@jasmeet0817
Copy link
Contributor

Will have a look tomorrow 👌🏽

monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Nov 24, 2021
@monsieurtanuki
feat: openfoodfacts#678 - explicitly selecting the bottom navigation tab
683dc9a 
Impacted files:
* `continuous_scan_page.dart`: explicitly select the "scan" tab
* `new_product_page.dart`: implicitly select the "default" tab
* `product_list_page.dart`: explicitly select the "history" tab
* `product_page.dart`: implicitly select the "default" tab
* `smooth_bottom_navigation_bar.dart`: now explicitly selecting the tab, instead of storing it in preferences
* `user_preferences.dart`: removed tab index preference
* `user_preferences_page.dart`: explicitly select the "profile" tab
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Nov 24, 2021
@monsieurtanuki
feat: openfoodfacts#678 - (forgot that one)
49b21a6 
Impacted file:
* `main.dart`: implicitly select the "default" tab and the matching page
@monsieurtanuki monsieurtanuki mentioned this issue Nov 25, 2021
Merged
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Nov 25, 2021
@monsieurtanuki
feat: openfoodfacts#678 - renaming getCurrentPage to getDefaultPage
5b51a2a
monsieurtanuki added a commit that referenced this issue Nov 25, 2021
@monsieurtanuki
feat: #678 - added bottom navigation bar to product page (#679)
212dd31 
The previous bottom navigation bottom bar was refactored, in order to be reused anywhere.
Then it was added to the product page.

Deleted files:
* `home_page.dart`
* `smooth_ui_library/smooth_bottom_navigation_bar.dart`
* `smooth_ui_library/smooth_bottom_navigation_bar_item.dart`

New file:
* `smooth_bottom_navigation_bar.dart`

Impacted files:
* `continuous_scan_page.dart`: added an explicit bottom navigation bar (was implicit through `HomePage`), explicitly on the "scan" tab
* `main.dart`: not using `HomePage` anymore; opens the "scan" page by default
* `new_product_page.dart`: added an explicit bottom navigation bar (was not there), implicitly on the "default" tab
* `product_list_page.dart`: added an explicit bottom navigation bar (was implicit through `HomePage`), explicitly on the "history" tab
* `product_page.dart`: added an explicit bottom navigation bar (was not there), implicitly on the "default" tab
* `smooth_ui_library.dart`: removed "UI" version of smooth bottom navigation bar
* `user_preferences_page.dart`:  added an explicit bottom navigation bar (was implicit through `HomePage`), explicitly on the "profile" tab
@monsieurtanuki monsieurtanuki linked a pull request Nov 25, 2021 that will close this issue
feat: #678 - added bottom navigation bar to product page #679
Merged
@monsieurtanuki
Copy link
Contributor Author

Done in #679.

@monsieurtanuki monsieurtanuki self-assigned this Nov 25, 2021
@github-actions github-actions bot mentioned this issue Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #678 - added bottom navigation bar to product page monsieurtanuki/smooth-app
2 participants
@jasmeet0817 @monsieurtanuki