-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow country & language selection from the settings #849
Comments
@teolemon Some remarks:
|
Yes, I am also in favour of keeping the language private |
AFAICR, default language is the device language, in which case I also
agree, we shouldn't make it configurable.
…On Wed, 5 Jan 2022 at 17:48, Marvin M ***@***.***> wrote:
Yes, I am also in favour of keeping the language private
—
Reply to this email directly, view it on GitHub
<#849 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZRHYSNORYYJFZWFGPCJQDUURY5XANCNFSM5LHOMV4A>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
--
Cheers,
Jasmeet Singh
|
Impacted files: * `country_selector.dart`: fixed an async bug; added facultative default country, decoration and padding * `user_preferences_profile.dart`: added a "select country" item * `welcome_page.dart`: added decoration and padding as parameters to `CountrySelector`
Impacted files: * `country_selector.dart`: now the initial value is required * `welcome_page.dart`: specify the now required initial value
Impacted files: * `country_selector.dart`: fixed an async bug; added facultative default country, decoration and padding * `user_preferences_profile.dart`: added a "select country" item * `welcome_page.dart`: added decoration and padding as parameters to `CountrySelector`
The public country part was done in #861. |
For the record you can already change the app language: just change the smartphone language. |
In my opinion it will be good to have the possibility to choose the language of the app from the settings because they are not so many languages that are fully translated.If someone want to add or edit a product its better that the information is correctly entered. |
I'm now working on this issue to confirm whether the app language is able to be changed, but I failed and this is my implementation. |
Heyy @UgoKo-Rubeast, we are already using shared_preferences, when I remember right it is not in the dependencies since it's build-in into flutter or something like that, I've just had a look at your #1729, and you are right, what you are doing there is updating the product preferences and not the main app. The article you send looks promising but as the language selection should probably be hidden for most users I don't think we need a provider for that, manually restarting the app should be more then enouph. What I would recommend:
|
* feature/849-add-language-selection * feature/849-add-language-selection add language selection to dev mode * feature/849-add-language-selection add context.select to main.dart for watching locale * feature/849-add-language-selection flutter format * feature/849-add-language-selection add app language reset to dev mode * feature/849-add-language-selection change app language reset from platform.localeName to null Co-authored-by: Pierre Slamich <[email protected]>
What
feat: #849 - added country selector to preferences page #861
Why
Part of
V1 screenshot
The text was updated successfully, but these errors were encountered: