Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten color/dark mode settings #919

Closed
4 tasks
Tracked by #960
, #684
...
teolemon opened this issue Jan 11, 2022 · 4 comments
Closed
4 tasks
Tracked by #960
, #684
...

Flatten color/dark mode settings #919

teolemon opened this issue Jan 11, 2022 · 4 comments
Assignees
@sgayangi
Labels
good first issue Good for newcomers 🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. P2 ⚙️ Settings 🎨 UI / UX

Comments

@teolemon
Copy link
Member

teolemon commented Jan 11, 2022 •
edited
Loading

What

  • Inline color settings
  • Inline dark mode
  • Give a name to the color accent section

Part of

Mockup

image
@teolemon teolemon mentioned this issue Jan 15, 2022
Open
11 tasks
@teolemon teolemon mentioned this issue Jan 29, 2022
Closed
14 tasks
@teolemon teolemon added 🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. good first issue Good for newcomers P2 🎨 UI / UX labels Mar 9, 2022
@sgayangi
Copy link
Contributor

sgayangi commented Mar 11, 2022 •
edited
Loading

Hi, I have been working on this issue and currently it looks like this. I just wanted to get some feedback before I posted a PR. Are there any changes or improvements I should make? I thank you for your time

Screenshot_20220311-160645

@M123-dev
Copy link
Member

Heyyy looks good @sgayangi, just from looking at it I'd say that the "Darkmode" could probably be the same style as the "Main color of the app", otherwise feel free to open a PR

@sgayangi sgayangi mentioned this issue Mar 11, 2022
Merged
@sgayangi
Copy link
Contributor

Thank you! I updated the font style and opened a PR.

@M123-dev M123-dev assigned M123-dev and sgayangi and unassigned M123-dev Mar 11, 2022
@M123-dev
Copy link
Member

Fixed by @sgayangi in #1195

Repository owner moved this from Todo to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgayangi sgayangi

Labels
good first issue Good for newcomers 🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. P2 ⚙️ Settings 🎨 UI / UX
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teolemon @M123-dev @sgayangi