Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Vertical axis for buttons in the permission dialog #2906

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Sep 2, 2022

One more case for vertical dialog buttons (mentionned in #2805)

I have also changed a little bit the code, because using a FittedBox would expand the Widget if the text is too small.

Screenshot_1662114964

@g123k g123k requested a review from a team as a code owner September 2, 2022 10:42
@codecov-commenter
Copy link

Codecov Report

Merging #2906 (ea9c453) into develop (f90e9f8) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #2906      +/-   ##
==========================================
+ Coverage     6.69%   6.71%   +0.02%     
==========================================
  Files          220     220              
  Lines        11140   11073      -67     
==========================================
- Hits           746     744       -2     
+ Misses       10394   10329      -65     
Impacted Files Coverage Δ
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 15.00% <0.00%> (ø)
packages/smooth_app/lib/pages/scan/scan_page.dart 4.00% <ø> (ø)
...s/smooth_app/lib/pages/scan/camera_controller.dart 0.00% <0.00%> (ø)
...es/smooth_app/lib/pages/scan/ml_kit_scan_page.dart 0.47% <0.00%> (+<0.01%) ⬆️
...s/smooth_app/lib/data_models/user_preferences.dart 9.89% <0.00%> (+1.15%) ⬆️
...b/pages/preferences/user_preferences_settings.dart 12.06% <0.00%> (+2.13%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon teolemon merged commit 779e8f4 into openfoodfacts:develop Sep 3, 2022
@g123k g123k deleted the dialog_vertical_permission branch September 3, 2022 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants