feat: 4510 - new "enroll in the beta" contribute item #4938
Conversation
Impacted files: * `app_en.arb`: added an "enroll in the beta" label. * `app_store.dart`: new `getEnrollInBetaURL` method * `apple_app_store.dart`: implements new `getEnrollInBetaURL` method * `google_play.dart`: implements new `getEnrollInBetaURL` method * `user_preferences_contribute.dart`: added an "enroll in the beta" button
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #4938 +/- ##
==========================================
+ Coverage 9.65% 9.66% +0.01%
==========================================
Files 323 322 -1
Lines 16207 16197 -10
==========================================
+ Hits 1564 1565 +1
+ Misses 14643 14632 -11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
- https://fonts.google.com/icons?selected=Material+Symbols+Outlined:labs:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=test&icon.platform=android
- Mention "internal alpha version" and not just beta. Probably a bottom sheet to get the user to acknowledge that: complete loss of data is possible, the apps may become unusable at any time.
|
@teolemon Instead of a bottom dialog, what about this: Regarding the icon, it looks like it's not accessible with flutter (cf. https://fonts.google.com/icons?icon.query=labs). |
|
@M123-dev I'll have to code a bit anyway, my screenshot was just a suggestion without a pushed code. |
|
Done: |
Co-authored-by: Pierre Slamich <[email protected]>
|
@teolemon For the record there's no space before an exclamation mark in English. |
|
What about using the SVG version ?
|
|
@teolemon If it's just a matter of filling the test tube that can be done: |
|
That looks more in line with the other icons 👍 |
packages/smooth_app/lib/pages/preferences/user_preferences_contribute.dart
Outdated
Show resolved
Hide resolved
monsieurtanuki
dismissed
teolemon’s stale review
All requested changes are there, now.
What
Screenshot
Fixes bug(s)
Impacted files
app_en.arb: added an "enroll in the beta" label.app_store.dart: newgetEnrollInBetaURLmethodapple_app_store.dart: implements newgetEnrollInBetaURLmethodgoogle_play.dart: implements newgetEnrollInBetaURLmethoduser_preferences_contribute.dart: added an "enroll in the beta" button