Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5079 - new deeplink to the Country Eco-Score #5152

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Added a link to country-related eco-score hunger games page on user welcome page.

Screenshot

Screenshot_1713005214

Fixes bug(s)

Impacted files

  • app_en.arb: 1 label added
  • app_fr.arb: 1 label added
  • user_preferences_account.dart: added a link to country eco-score on user welcome page

Impacted files:
* `app_en.arb`: 1 label added
* `app_fr.arb`: 1 label added
* `user_preferences_account.dart`: added a link to country eco-score on user welcome page
@monsieurtanuki
Copy link
Contributor Author

@alexfauquette The redirection does work. I couldn't test if the deep link worked.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 9.52%. Comparing base (4d9c7fc) to head (e607974).
Report is 68 commits behind head on develop.

Files Patch % Lines
...ib/pages/preferences/user_preferences_account.dart 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5152      +/-   ##
==========================================
- Coverage     9.54%   9.52%   -0.03%     
==========================================
  Files          325     327       +2     
  Lines        16411   16561     +150     
==========================================
+ Hits          1567    1578      +11     
- Misses       14844   14983     +139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review and @alexfauquette for your additional code!

@monsieurtanuki monsieurtanuki merged commit 2ee3cd8 into openfoodfacts:develop Apr 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leverage the new deeplink to the Hunger Games Eco-Score dashboard by country
3 participants