Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

closing tabs doesnt dispose voila kernels #336

Open
dfguerrerom opened this issue Nov 22, 2024 · 0 comments
Open

closing tabs doesnt dispose voila kernels #336

dfguerrerom opened this issue Nov 22, 2024 · 0 comments
Assignees
Labels

Comments

@dfguerrerom
Copy link
Contributor

We already have discussed this, but I just want to track the progress on this issue.

If you open sepal_ui or jupyter based applications, when you close the sepal tab, the kernel doesn't get killed and therefore it remains as ghost, consuming memory.

The problem happens because voila only kills the kernel when the app is loaded in a tab and the tab is closed, producing a beforeunload event which sends a beacon: https://github.com/voila-dashboards/voila/blob/9982c78931fd5fbab60b4edc5f00cb353665c9a2/packages/widgets_manager8/src/index.ts#L75, when sepal closes a tab, it doesn't produce that event and therefore the kernel remains running.

Also, in sepal.io, when the app is launched as independent browser tab, the beacon is not sent properly in Mozilla, I have reported the error here jupyter-server/jupyter_server#1466.

@dfguerrerom dfguerrerom self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant