Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't retrieve the geometries #919

Closed
dfguerrerom opened this issue May 15, 2024 · 2 comments
Closed

don't retrieve the geometries #919

dfguerrerom opened this issue May 15, 2024 · 2 comments
Assignees

Comments

@dfguerrerom
Copy link
Collaborator

Is there a need to "download" the AOI if the AoiModel is instantiated with the gee parameter?
If I create a GEE app, there are only few and specific cases (or is there even any?) where I want to retrieve the features from GEE and then store them as GeoDataFrame in the object,
I think we should not make this expensive process as the default behavior every time an AOI is created, this is not useful, and it is even worst if a vector file is selected from the client side: it uploads it and then it downlaods it.

@dfguerrerom dfguerrerom self-assigned this May 15, 2024
@dfguerrerom dfguerrerom changed the title don't retrieve the json geometry? don't retrieve the geometries May 15, 2024
@12rambau
Copy link
Member

my inistial though was consistency.
Whatever we do we always have the same thing: a GEE asset and a geodataframe available.
What could be done is to create them as properties and only compute it upon request.

@dfguerrerom
Copy link
Collaborator Author

Actually, that's not always the case:

  • from_asset (gee) method doesn't create a gdf (and it shouldn't).
  • from_points, from_vector and from_geo_json only create the feature_collection if it is requested.
  • from_admin is the only gee method which also creates a gdf, and I think we do that because we need to set a name for the feature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants