Prevent false positive

thomas-kl1 · web-flow · commit 908e5b3e5e09 · 2024-03-19T19:55:59.000+01:00
diff --git a/App/Request/PathInfoProcessor.php b/App/Request/PathInfoProcessor.php
@@ -29,7 +29,7 @@ public function __construct(
     public function process(RequestInterface $request, $pathInfo): string
     {
         $storeCode = $this->storePathInfoValidator->getValidStoreCode($request, $pathInfo);
-        if (!empty($storeCode)) {
+        if ($storeCode !== null) {
             try {
                 $path = $this->pathResolver->resolve($this->storeRepository->getActiveStoreByCode($storeCode));
             } catch (LocalizedException) {

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ public function __construct(`
`29`	`29`	`public function process(RequestInterface $request, $pathInfo): string`
`30`	`30`	`{`
`31`	`31`	`$storeCode = $this->storePathInfoValidator->getValidStoreCode($request, $pathInfo);`
`32`		`- if (!empty($storeCode)) {`
	`32`	`+ if ($storeCode !== null) {`
`33`	`33`	`try {`
`34`	`34`	`$path = $this->pathResolver->resolve($this->storeRepository->getActiveStoreByCode($storeCode));`
`35`	`35`	`} catch (LocalizedException) {`