Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade openid-client to latest #23

Merged
merged 1 commit into from
Mar 29, 2023
Merged

chore: Upgrade openid-client to latest #23

merged 1 commit into from
Mar 29, 2023

Conversation

natashaannn
Copy link
Contributor

Problem

openid-client shows warnings on npm install on Node 18. Closes #22.
There are also 2 dependency vulnerabilities flagged by npm.

Solution

Installed latest version of [email protected].
Also ran npm audit fix to fix dependency vulnerabilities.

Before & After Screenshots

BEFORE:
On npm i on Node 18, the below warnings would appear:

➜  sgid-client git:(develop) npm i
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '^12.19.0 || ^14.15.0 || ^16.13.0' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.5.0' }
npm WARN EBADENGINE }

> @opengovsg/[email protected] prepare
> husky install

husky - Git hooks installed

added 302 packages, and audited 303 packages in 34s

26 packages are looking for funding
  run `npm fund` for details

2 high severity vulnerabilities

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

AFTER:
On npm i on Node 18, there should be no warnings:

➜  sgid-client git:(chore/upgrade-openid) npm i

> @opengovsg/[email protected] prepare
> husky install

husky - Git hooks installed

up to date, audited 304 packages in 567ms

27 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

New dependencies:

mantariksh
mantariksh reviewed Mar 29, 2023
View reviewed changes
Copy link
Contributor

@mantariksh mantariksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment, thanks for the contribution!

package.json Outdated Show resolved Hide resolved
@natashaannn
chore: Upgrade openid-client to latest
d2240f8 
Closes opengovsg#22

Also ran npm audit fix to fix vulnerable dependencies
@natashaannn natashaannn force-pushed the chore/upgrade-openid branch from 3750bf7 to d2240f8 Compare March 29, 2023 04:35
@mantariksh mantariksh merged commit f4237ae into opengovsg:develop Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade openid-client to latest to fix warnings on Node 18
2 participants
@natashaannn @mantariksh