Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK to reference well-known endpoint #41

Closed
raynerljm opened this issue May 5, 2023 · 2 comments
Closed

Update SDK to reference well-known endpoint #41

raynerljm opened this issue May 5, 2023 · 2 comments

Comments

@raynerljm
Copy link
Contributor

raynerljm commented May 5, 2023

Currently, the SDK is constructing its own values for the necessary endpoints

Image

Update the SDK to reference the well-known endpoint according to the OpenID Discovery RFC

@kwajiehao
Copy link
Contributor

From our offline discussion:

Jie Hao: "if our SDK references the well-known endpoint, this means that our SDK will need to make an extra API call which adds more latency for the RP app. I'm not sure if this tradeoff (extra latency for correctness of OIDC endpoints) is worth it given that we control both the SDK and the API server"

@kwajiehao
Copy link
Contributor

Closing this issue because there's no urgent need for us to use the well-known endpoint in our SDK as our team is small and develops all products involved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants