add environmental variables and set up secret detection #1508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the GitHub Actions ci seems to be failing here: hmm |
LoneRifle
requested changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit closes #1261.
npm run devis not working becauseenv-cmdis expecting an env file in the root directory.env.examplefile to the backend, updates the README to tell the user to duplicate a.envfile. After doing so,npm run devwill work properly.Second commit is based on Postman's PR opengovsg/postmangovsg#1554, which was made after we our previous secret detection linter failed to pick up secret. We experimented with a few options and
detect-secretswork the best.detect-secretsNot sure if I've set up the
ci.ymland husky hooks properly — would be good to have someone look through them!