Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tellstick] support add-on suggestions via USB finder #16139

Closed
andrewfg opened this issue Dec 29, 2023 · 9 comments
Closed

[tellstick] support add-on suggestions via USB finder #16139

andrewfg opened this issue Dec 29, 2023 · 9 comments
Assignees
Labels
enhancement An enhancement or new feature for an existing add-on

Comments

@andrewfg
Copy link
Contributor

It looks like this binding depends on a USB stick to connect to OH (??) so in theory the binding could be automatically suggested via the core USB add-on suggestion finder. If that is the case, it simply needs the respective discovery-methods to be added to the binding's addon.xml file.

Signed-off-by: Andrew Fiddian-Green [email protected]

@andrewfg andrewfg added the enhancement An enhancement or new feature for an existing add-on label Dec 29, 2023
@lsiepel
Copy link
Contributor

lsiepel commented Dec 30, 2023

tellstick as no active maintainer, so maybe it is better to ask in the communities for an active user to confirm and or list usb details?

@wborn
Copy link
Member

wborn commented Jan 3, 2024

I think it uses 1781:0c31 after a bit of Googling. However the binding is broken, see #15987.

@andrewfg
Copy link
Contributor Author

andrewfg commented Jan 4, 2024

I think it uses 1781:0c31 after a bit of Googling

Ok. As there is no active maintainer I could raise a PR to add that.

the binding is broken, see #15987

@wborn is that a subtle hint that I should try to fix also in my PR? I do not use this binding so the fix would be rather 'ad hoc' though. Is that Ok?

@lsiepel
Copy link
Contributor

lsiepel commented Jan 4, 2024

I think that is ok, and if you want to it would be great, there seem to be atleast two people in the other thread that might offer to test a fix. I don't have the stick, so i can't test, but can review the code.

@wborn
Copy link
Member

wborn commented Jan 4, 2024

is that a subtle hint that I should try to fix also in my PR?

Users may be disappointed when they are suggested to install a broken binding. 😉

Maybe @dabj123 or @ulfwin can provide the output of lsusb -v?

@ulfwin
Copy link
Contributor

ulfwin commented Jan 4, 2024

I'm afraid I only have tellstick net and znet, which connects through Ethernet...

@dabj123
Copy link

dabj123 commented Jan 5, 2024

Ah sorry, I only have tellstick which connects through Ethernet...

@andrewfg
Copy link
Contributor Author

andrewfg commented Jan 6, 2024

@wborn @lsiepel see #16220

@andrewfg
Copy link
Contributor Author

Closed via #16228

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

No branches or pull requests

5 participants