Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MainUI] Allow color settings for own svg icons #2679

Open
sKinyo opened this issue Jul 20, 2024 · 1 comment
Open

[MainUI] Allow color settings for own svg icons #2679

sKinyo opened this issue Jul 20, 2024 · 1 comment
Labels
enhancement New feature or request main ui Main UI

Comments

@sKinyo
Copy link

sKinyo commented Jul 20, 2024

The problem

Because I don't like the internal and most of the external icons I have created my own svg icons.
I can integrate them with the components svg and use in widgets and can set a color.
This shows the icon but can't directly use them in oh-list-item, oh-label-item, oh-icon, oh-botton, oh-link, and all others.

The BasicUI allows colors for own icons but this is missing in the MainUI

Your suggestion

Internal/own svg icons should have the same feature set as external icons.
Allow to set a css color.

This should be possible:

- component: oh-icon
  config:
    icon: oh:my_own_icon
    color: "#BDB76B"
- component: oh-list-item
  config:
    icon: oh:my_own_icon
    iconColor: "#BDB76B"

Your environment

runtimeInfo:
  version: 4.2.0
  buildString: Release Build

Additional information

@sKinyo sKinyo added enhancement New feature or request main ui Main UI labels Jul 20, 2024
@lolodomo
Copy link
Contributor

lolodomo commented Sep 7, 2024

For Main UI developers, the way to achieve that (control icon colour) in Basic UI is to use inline SVG and this is optional, disabled by default. It requires to download SVG icons and inject them in the page as inline and it leads to pages having obviously a bigger size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

No branches or pull requests

2 participants