New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native browser `alert()`s seem odd and should be replaced by Opal UI? #1592

Open

pacharanero opened this issue Apr 23, 2018 · 2 comments

Labels

Contributor

pacharanero commented Apr 23, 2018

There are a couple in this controller, but there may be others. Would we be able to make it so these alerts used a nicer-looking notification?

elcid/walkin/static/js/walkin/controllers/walkin_hospital_number.js

Line 139 in 961aad5

alert('Patient is currently on the Walkin Review list. Moving them here.');

pacharanero added Design GUI labels

Contributor Author

pacharanero commented Apr 23, 2018

Member

davidmiller commented Apr 23, 2018

See also:

openhealthcare/opal#751

And a first pass implementation:

openhealthcare/opal@d551b8c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment