New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

font awesome 5 #1447

Open

fredkingham opened this issue Mar 9, 2018 · 1 comment

Contributor

fredkingham commented Mar 9, 2018 •

edited

Loading

A speculative, can we upgrade to font awesome 5. If so please upgrade

Do all existing icons from 4 continue working in 5.

If not is it possible to include both until we have time to remove everything from 4?

Update the Changelog with whatever outcome occurs.

fredkingham assigned ghickman

davidmiller unassigned ghickman

Member

davidmiller commented Apr 21, 2018

It's quite a lot more complicated than previous upgrades.

The compatibility shim to prevent the need to deal with extensive icon renaming has only been implemented for the JS + SVG method.

This method is incompatible with

our extensive use of click handlers on <i> elements
multiple css classes which rely on the webfont (.scrollToTop:before, .fake-select-wrapper:after, .nav-bar-search:before)

We'll likely need to actively review each of the quite long list of changed icon names here: https://fontawesome.com/how-to-use/upgrading-from-4 and upgrade wholesale without the shim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment