Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Non-Hash Auth Code Redirects #211

Open
chrisguitarguy opened this issue May 25, 2022 · 0 comments
Open

Support Non-Hash Auth Code Redirects #211

chrisguitarguy opened this issue May 25, 2022 · 0 comments

Comments

@chrisguitarguy
Copy link

Expected Behavior

I can handled an auth code redirect with a query string, not just a hash.

[REQUIRED] Describe expected behavior

When I call completeAuthorizationRequestIfPossible i'd like it to look at the query string if some configuration option is set.

This line:

let queryParams = this.utils.parse(this.locationLike, true /* use hash */);
it'd be cool if could handle query strings or hashes.

Describe the problem

See above. My oauth server returns query strings, not hashes. Would like to be able to use this library in browser.

[REQUIRED] Actual Behavior

Second half of the oauth flow never completes, since the code, state, etc, are all in the query string, not hash.

[REQUIRED] Steps to reproduce the behavior

Use an oauth server that sends back an auth code response in a query string.

[REQUIRED] Environment

  • AppAuth-JS version: 1.3.1
  • AppAuth-JS Environment (Node, Browser (UserAgent), ...):Browser
  • Source code snippts (inline or JSBin)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant