Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: In release-v3.7, msg seq increase not use redis incr #2549

Open
zshen-wish opened this issue Aug 23, 2024 · 2 comments
Open

[Bug]: In release-v3.7, msg seq increase not use redis incr #2549

zshen-wish opened this issue Aug 23, 2024 · 2 comments
Assignees
Labels
other Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@zshen-wish
Copy link

What would you like to share?

https://github.com/openimsdk/open-im-server/blob/release-v3.7/pkg/common/db/controller/msg.go#L385
Not use redis incr may cause some concurrency issue, or it is my misunderstanding?

Additional information

No response

@zshen-wish zshen-wish added the other Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 23, 2024
@OpenIM-Robot
Copy link

Hello! Thank you for filing an issue.

If this is a bug report, please include relevant logs to help us debug the problem.

Join slack 🤖 to connect and communicate with our developers.

@zshen-wish zshen-wish changed the title [Other]: In release-v3.7, msg seq increase not use redis incr [Bug]: In release-v3.7, msg seq increase not use redis incr Aug 28, 2024
@FGadvancer
Copy link
Member

For transfer consumption, coroutine sharding ensures session serialization processing, and it is handled in batches. Therefore, a set is used instead of incr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
other Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

3 participants