Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix https://github.com/openimsdk/open-im-server/issues/2895 #2896

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

morya
Copy link
Contributor

@morya morya commented Nov 26, 2024

🅰 Please add the issue ID after "Fixes #"

Fixes #2895

@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 26, 2024
@skiffer-git
Copy link
Member

[2024-11-26 09:10:25 UTC] Some programs are not running properly:
binary openim-msggateway is not running as expected: /home/runner/work/open-im-server/open-im-server/_output/bin/platforms/linux/amd64/openim-msggateway expected 1 processes, but 0 running

@morya
Copy link
Contributor Author

morya commented Nov 28, 2024

[2024-11-26 09:10:25 UTC] Some programs are not running properly: binary openim-msggateway is not running as expected: /home/runner/work/open-im-server/open-im-server/_output/bin/platforms/linux/amd64/openim-msggateway expected 1 processes, but 0 running

when there are no rpc.ports config inside './config/openim-msggateway.yml' , code will fail to run due to index error.

last commit fix it.

@morya
Copy link
Contributor Author

morya commented Dec 4, 2024

conflict has been resolved

@icey-yu icey-yu enabled auto-merge December 4, 2024 03:16
@icey-yu icey-yu added this pull request to the merge queue Dec 4, 2024
Merged via the queue into openimsdk:main with commit a69d174 Dec 4, 2024
8 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
@FGadvancer FGadvancer added this to the 3.8.3 milestone Dec 12, 2024
@mo3et mo3et modified the milestones: v3.8.3, v3.9.0 Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] no need to specify port and ports in config for RPC services
5 participants