Skip to content

Conversation

@xmas92
Copy link
Member

@xmas92 xmas92 commented Nov 12, 2025

Trivial change to remove the VMOp symbols from the VM_OPS_DO macro which were left over after the removal of the non-generational ZGC. (JDK-8335850)

  • Testing
    • GHA

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8371675: ZGC: Remove leftover X VMOp symbols (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28252/head:pull/28252
$ git checkout pull/28252

Update a local copy of the PR:
$ git checkout pull/28252
$ git pull https://git.openjdk.org/jdk.git pull/28252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28252

View PR using the GUI difftool:
$ git pr show -t 28252

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28252.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 12, 2025

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371675: ZGC: Remove leftover X VMOp symbols

Reviewed-by: jsikstro, stefank, tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 82 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Nov 12, 2025

@xmas92 The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 12, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 12, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 12, 2025
@xmas92
Copy link
Member Author

xmas92 commented Nov 13, 2025

Thanks for the reviews
/integrate

@openjdk
Copy link

openjdk bot commented Nov 13, 2025

Going to push as commit d91480b.
Since your change was applied there have been 90 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 13, 2025
@openjdk openjdk bot closed this Nov 13, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 13, 2025
@openjdk
Copy link

openjdk bot commented Nov 13, 2025

@xmas92 Pushed as commit d91480b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime [email protected] integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants