8371672: G1: G1YoungGenSizer handling of NewRatio, NewSize and MaxNewSize

[xmas92]

G1YoungGenSizer ignores these values if they are not from the command line. Resulting in a different _sizer_kind than expected.
The NewSize and MaxNewSize are also not bounded by the Initial and Max heap size respectively (JDK-8370494).

I suggest we rewrite this logic using !FLAG_IS_DEFAULT to always get the correct behaviour. And only use FLAG_IS_CMDLINE for issuing warnings to the user when we ergonomically change or ignore these values to be compatible.
As well as adding the proper truncation for HeapSize incompatible values.

• Testing
  • GHA
  • Tier 1-5 on Oracle Supported Platforms

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8371672: G1: G1YoungGenSizer handling of NewRatio, NewSize and MaxNewSize (Bug - P4)
• JDK-8370494: G1: NewSize not bounded by InitialHeapSize or MaxHeapSize (Bug - P5)

Reviewers

• Ivan Walulya (@walulyai - Reviewer) Review applies to 91b86362
• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/28255/head:pull/28255
$ git checkout pull/28255

Update a local copy of the PR:
$ git checkout pull/28255
$ git pull https://git.openjdk.org/jdk.git pull/28255/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 28255

View PR using the GUI difftool:
$ git pr show -t 28255

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/28255.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aboldtch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@xmas92 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8371672: G1: G1YoungGenSizer handling of NewRatio, NewSize and MaxNewSize
8370494: G1: NewSize not bounded by InitialHeapSize or MaxHeapSize

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 101 new commits pushed to the master branch:

• 7d78818: 8274178: G1: Occupancy value in IHOP logging and JFR event is inaccurate
• bbc0f9e: 8371788: Fix documentation for CollectedHeap::collect(GCCause)
• 6b6fdf1: 8357874: UNLIMTED_CRYPTO typo in class description of JceSecurity.java.template
• ... and 98 more: https://git.openjdk.org/jdk/compare/c754e3e095cd367de9d3f69a4afb0c4be53a9342...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@xmas92 The following label will be automatically applied to this pull request:

• hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (afba48e6)
• 00: Full (91b86362)

[walulyai]

/issue add JDK-8370494

[openjdk]

@walulyai Only the author (@xmas92) is allowed to issue the /issue command.

[xmas92]

/issue add JDK-8370494

[openjdk]

@xmas92
Adding additional issue to issue list: 8370494: G1: NewSize not bounded by InitialHeapSize or MaxHeapSize.

[walulyai]

postcond(